Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): move old redux code to redux toolkit #594

Merged
merged 12 commits into from
Jan 23, 2024

Conversation

dubisdev
Copy link
Contributor

@dubisdev dubisdev commented Jan 6, 2024

As the official docs says the createStore method is deprecated. This PR moves all the stores to redux-toolkit which is:

  • Less verbose (also less code)
  • Better supporting TypeScript
  • Easier to understand

@dubisdev
Copy link
Contributor Author

dubisdev commented Jan 6, 2024

Hi @sekwah41 this PR is ready for now.

The new redux code for the tasks store is missing, but we can migrate it in other PR (this PR is big enought and the tasks store is more complex as it uses redux-undo).

@dubisdev dubisdev marked this pull request as ready for review January 6, 2024 23:21
@sekwah41
Copy link
Member

sekwah41 commented Jan 7, 2024

Ill try to review this tomorrow, though will review it at least at some point next week :)

@sekwah41 sekwah41 self-requested a review January 7, 2024 01:23
@dubisdev
Copy link
Contributor Author

Hey @sekwah41 any news on this?

I know it's a big PR but I think it's worth it having this merged before creating another store to save the custom shortcuts settings

@sekwah41
Copy link
Member

Sorry my bad. I should have time tomorrow but if I can I'll do it tonight.

@sekwah41 sekwah41 merged commit 326946f into zidoro:master Jan 23, 2024
3 checks passed
@sekwah41
Copy link
Member

Tested on both the electron and tauri versions and seems fine

@dubisdev dubisdev deleted the chore-redux-toolkit branch January 24, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Done
Development

Successfully merging this pull request may close these issues.

2 participants