-
Notifications
You must be signed in to change notification settings - Fork 29
Gnome 47 support #72
base: main
Are you sure you want to change the base?
Gnome 47 support #72
Conversation
Excellent! Thank you, @cryptbrn; I hope this gets merged and published as soon as possible. |
I can verify that it works under Gnome47. @zhrexl it has been one month since this pull request has been created. Just want to make sure that this doesn't get forgotten / missed. |
getColorFromString(string, fallback) { | ||
let [colorString, displayName] = string.split(':'); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Excellent, thanks @cryptbrn ! |
It is been more than a month since this pull request has been opened, and even the reminder has seen no reaction. No activity from @zhrexl has been seen on github since July. I think it is sadly safe to @zhrexl isn't here to continue maintaining this extension. Hope he is well and just has other priorities and interests. @cryptbrn would you be interested in taking over as a maintainer and uploading a new version to extensions.gnome.org? |
If @cryptbrn doesn't want to, and we don't hear back from zhrexl, then I would be interested in maintaining this project. I'd prefer to do it under my roof (either by taking ownership of the current repo from zhrexl or forking a new one, aka DrawOnYourScreen3). |
Thank you for taking the initiative, @daveprowse .
I see you have created the fork . I don't think more is needed on github's side. On gnome's side a ticket to transfer ownership is required. See OpenWeather's request as an example. Publishing with a new version number like DrawOnYourScreen3 gets rejected. DrawOnYourScreen2 was the only extension I now of that had that. And even that's page on e.g.o had been deleted. So ask for the transfer from the original version instead. That's just my two cents.
I'm rather certain, that no such requirement exists. |
Thanks @adaschma ! Those links were very enlightening. I haven't uploaded a gnome extension yet. Looks interesting. Looking ahead, it would be nice if we could set up separate gnome versions. But I wonder if it would be best to do separate branches or separate directories in the main branch for each version. I'm open to suggestions. Thanks again! |
I think we should plan for not hearing anything from @zhrexl, sadly. A quick look at the review guidelines I don't see any obvious problems. Uploading a version to e.g.o might be the fastest (and maybe only) way to get to know if and which changes are needed. If/when you get a list, feel free to share it. Maybe we can share some of the work.
That shouldn't be a problem. When the maintainer isn't replying it can be transferred without that. E.g.: Bluetooth Quick Connect's Request
I have a strong distaste for using separate directories for different versions. It prevents being to use git's tooling to make changes on both versions (e.g. git cherry-pick). When the changes between versions isn't large doing it with if-else or try-catch can be an alternative, as found in the guide. Though lets think about that once a version is in e.g.o. |
Thanks @adaschma , I opened an issue: #77 where I am asking @zhrexl for explicit permission to take over as maintainer. (I thought it was the right thing to do.) Also, I opened it up for anyone else to object, or to support me. I re-forked the repo (with all branches). I now have a working branch for GNOMEv47 and support v43 (in the v42 branch), and am working on support for v45. Here's my plan - feel free to add your thoughts:
|
Changelog: