Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Gnome 47 support #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Gnome 47 support #72

wants to merge 1 commit into from

Conversation

cryptbrn
Copy link
Contributor

Changelog:

  • Change Clutter.Color to Cogl.Color (Clutter.Color deprecated in Clutter 15)

@ccjmne
Copy link

ccjmne commented Sep 29, 2024

Excellent!

Thank you, @cryptbrn; I hope this gets merged and published as soon as possible.

@jougs jougs mentioned this pull request Oct 10, 2024
@adaschma
Copy link

I can verify that it works under Gnome47. @zhrexl it has been one month since this pull request has been created. Just want to make sure that this doesn't get forgotten / missed.

Comment on lines 1474 to 1475
getColorFromString(string, fallback) {
let [colorString, displayName] = string.split(':');

This comment was marked as resolved.

This comment was marked as resolved.

@daveprowse
Copy link

daveprowse commented Oct 31, 2024

Excellent, thanks @cryptbrn !
The export const StaticColor declaration in elements.js was giving me fits. Couldn't figure it out. Just needed that [1] at the end of each line 😁. You're awesome!
(These mods work for me on Debian Sid with GNOME 47)

@adaschma
Copy link

It is been more than a month since this pull request has been opened, and even the reminder has seen no reaction. No activity from @zhrexl has been seen on github since July. I think it is sadly safe to @zhrexl isn't here to continue maintaining this extension. Hope he is well and just has other priorities and interests.

@cryptbrn would you be interested in taking over as a maintainer and uploading a new version to extensions.gnome.org?

@daveprowse
Copy link

daveprowse commented Nov 1, 2024

It is been more than a month since this pull request has been opened, and even the reminder has seen no reaction. No activity from @zhrexl has been seen on github since July. I think it is sadly safe to @zhrexl isn't here to continue maintaining this extension. Hope he is well and just has other priorities and interests.

@cryptbrn would you be interested in taking over as a maintainer and uploading a new version to extensions.gnome.org?

If @cryptbrn doesn't want to, and we don't hear back from zhrexl, then I would be interested in maintaining this project. I'd prefer to do it under my roof (either by taking ownership of the current repo from zhrexl or forking a new one, aka DrawOnYourScreen3).
My guess is that the GNOME extensions group is going to want compatible versions going back as far as gnome-shell 43 before they will approve it. Could get tricky. However, I run all kinds of Linux systems both physical and virtual, so at least testing wouldn't be a problem. (just time consuming!)
My javascript skills are rusty (as are my git skills) but I'd be willing to polish them because I use this tool everyday (and it is far superior to anything else that I have found for Linux).
Also, it would be a good way to give back to the OSS community a little bit. :)

@adaschma
Copy link

adaschma commented Nov 1, 2024

If @cryptbrn doesn't want to, and we don't hear back from zhrexl, then I would be interested in maintaining this project.

Thank you for taking the initiative, @daveprowse .

I'd prefer to do it under my roof (either by taking ownership of the current repo from zhrexl or forking a new one, aka DrawOnYourScreen3).

I see you have created the fork . I don't think more is needed on github's side. On gnome's side a ticket to transfer ownership is required. See OpenWeather's request as an example. Publishing with a new version number like DrawOnYourScreen3 gets rejected. DrawOnYourScreen2 was the only extension I now of that had that. And even that's page on e.g.o had been deleted. So ask for the transfer from the original version instead. That's just my two cents.

My guess is that the GNOME extensions group is going to want compatible versions going back as far as gnome-shell 43 before they will approve it.

I'm rather certain, that no such requirement exists.

@daveprowse
Copy link

daveprowse commented Nov 2, 2024

Thanks @adaschma ! Those links were very enlightening. I haven't uploaded a gnome extension yet. Looks interesting.
I do see @zhrexl mentioning here #61 (comment) that a lot of old code has to be removed before gnome will accept it. I wonder how deep the rabbit hole goes?
I'm going to reach out to @zhrexl directly to find out status and also get an approximate amount of work required for acceptance. Hopefully I hear back.
The original DrawOnYourScreen author @abakkk has not responded to any messages, so ownership transfer might be difficult.

Looking ahead, it would be nice if we could set up separate gnome versions. But I wonder if it would be best to do separate branches or separate directories in the main branch for each version. I'm open to suggestions.

Thanks again!

@adaschma
Copy link

adaschma commented Nov 2, 2024

Thanks @adaschma ! Those links were very enlightening. I haven't uploaded a gnome extension yet. Looks interesting. I do see @zhrexl mentioning here #61 (comment) that a lot of old code has to be removed before gnome will accept it. I wonder how deep the rabbit hole goes? I'm going to reach out to @zhrexl directly to find out status and also get an approximate amount of work required for acceptance. Hopefully I hear back.

I think we should plan for not hearing anything from @zhrexl, sadly.

A quick look at the review guidelines I don't see any obvious problems. Uploading a version to e.g.o might be the fastest (and maybe only) way to get to know if and which changes are needed. If/when you get a list, feel free to share it. Maybe we can share some of the work.

The original DrawOnYourScreen author @abakkk has not responded to any messages, so ownership transfer might be difficult.

That shouldn't be a problem. When the maintainer isn't replying it can be transferred without that. E.g.: Bluetooth Quick Connect's Request

Looking ahead, it would be nice if we could set up separate gnome versions. But I wonder if it would be best to do separate branches or separate directories in the main branch for each version. I'm open to suggestions.

I have a strong distaste for using separate directories for different versions. It prevents being to use git's tooling to make changes on both versions (e.g. git cherry-pick). When the changes between versions isn't large doing it with if-else or try-catch can be an alternative, as found in the guide. Though lets think about that once a version is in e.g.o.

@daveprowse
Copy link

daveprowse commented Nov 4, 2024

Thanks @adaschma , I opened an issue: #77 where I am asking @zhrexl for explicit permission to take over as maintainer. (I thought it was the right thing to do.) Also, I opened it up for anyone else to object, or to support me.
I also tried contacting @zhrexl at the "Buy me a coffee" page (which I did) and several other links that I found.
If I don't hear from @zhrexl in 10 days, I will move forward with extensions.gnome.org.

I re-forked the repo (with all branches). I now have a working branch for GNOMEv47 and support v43 (in the v42 branch), and am working on support for v45. Here's my plan - feel free to add your thoughts:

  • Unify GNOME v46 and v47
  • Get that version accepted by extensions.gnome.org (the hard part)
  • Set up scripted installs in the meantime
  • A bunch of other stuff that escapes me at the moment!
    Thanks again

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants