nixos: Allow settings to be omitted with null #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for suppressing the default database.url setting in the NixOS module. In the future, we need to rethink about the precedence of configuration sources. It makes sense for the environment variables to take precedence over configuration files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ATTIC_SERVER_DATABASE_URL,PGUSERNAMEandPGPASSWORDenvironment variables already work, but there are paper cuts when using them with the NixOS module:database.urlby default, which cannot easily suppressed if you intend to setATTIC_SERVER_DATABASE_URL[database]section being omitted entirelyAlternative: Instead of allowing settings to be null in the module, we can add an
useSqlite/addSqliteDefaultsoption that defaults to true.In the future, we need to rethink about the precedence of configuration sources. It makes sense for the environment variables to take precedence over configuration files.
Ref: #152.