Skip to content

Commit

Permalink
required to import sass-config
Browse files Browse the repository at this point in the history
  • Loading branch information
@gabiezur
gabiezur committed Dec 14, 2016
1 parent 060428e commit 371672d
Show file tree
Hide file tree
Showing 4 changed files with 53 additions and 20 deletions.
2 changes: 1 addition & 1 deletion bower.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "sass-bem",
"version": "2.6.2",
"version": "2.6.3",
"main": "_bem.scss",
"description": "Amazing package for sass to write bem classes, with namespaces and more advanced features.",
"authors": [
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "sass-bem",
"version": "2.6.2",
"version": "2.6.3",
"description": "Amazing package for sass to write bem classes, with namespaces and more advanced features.",
"main": "_bem.scss",
"repository": {
Expand Down
6 changes: 5 additions & 1 deletion src/_config.scss
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@charset "UTF-8";

@import "../node_modules/sass-config/config";
//@import "../node_modules/sass-config/config";

This comment has been minimized.

Sign in to view

Copy link
@MartinN3

MartinN3 Dec 18, 2016

Contributor

is this intended ? Why not uncomment and do it like this @import "../../node_modules/sass-config/config"; -> because you are now in src/ and need two levels up.

If this is intended, how to work with sass-bem package - Readme must be updated accordingly.

/// Default sass-bem configuration settings.
///
Expand Down Expand Up @@ -32,6 +32,10 @@
///
/// @access public

@if not function-exists(config) {

This comment has been minimized.

Sign in to view

Copy link
@MartinN3

MartinN3 Dec 18, 2016

Contributor

In 2.5v sass-config was optional. Now in 2.6v its must. OK thats not problem but my build with default install ( npm install sass-bem --save ) that adds carret ^ for example: "sass-bem":"^2.5.3" FAILS
@error 'sass-config package need to be imported before sass-bem package';
}

$bem: (
'debug': false,
'separator': (
Expand Down
63 changes: 46 additions & 17 deletions test/test.css
View file
Original file line number Diff line number Diff line change
@@ -1,22 +1,51 @@
/*
Error: File to import not found or unreadable: true.
on line 2 of test.scss
1: @import "../bem";
2: @import "true";
3:
4: $true-terminal-output: true;
5:
6: @import "functions";
7: @import "helpers";
Error: sass-config package need to be imported before sass-bem package
on line 36 of ../src/_config.scss
from line 9 of ../_bem.scss
from line 1 of test.scss
Backtrace:
test.scss:2
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/import_node.rb:67:in `rescue in import'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/import_node.rb:45:in `import'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/import_node.rb:28:in `imported_file'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/import_node.rb:37:in `css_import?'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:313:in `visit_import'
../src/_config.scss:36
../_bem.scss:9
test.scss:1
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:226:in `visit_error'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/base.rb:36:in `visit'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:160:in `block in visit'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:79:in `block in with_base'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:115:in `with_frame'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:79:in `with_base'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:160:in `visit'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:301:in `block (2 levels) in visit_if'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:301:in `map'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:301:in `block in visit_if'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:181:in `with_environment'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:300:in `visit_if'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/base.rb:36:in `visit'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:160:in `block in visit'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:79:in `block in with_base'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:115:in `with_frame'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:79:in `with_base'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:160:in `visit'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:328:in `block (2 levels) in visit_import'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:328:in `map'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:328:in `block in visit_import'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:88:in `block in with_import'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:115:in `with_frame'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:88:in `with_import'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:325:in `visit_import'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/base.rb:36:in `visit'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:160:in `block in visit'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:79:in `block in with_base'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:115:in `with_frame'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:79:in `with_base'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:160:in `visit'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:328:in `block (2 levels) in visit_import'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:328:in `map'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:328:in `block in visit_import'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:88:in `block in with_import'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:115:in `with_frame'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:88:in `with_import'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:325:in `visit_import'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/base.rb:36:in `visit'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/tree/visitors/perform.rb:160:in `block in visit'
/Users/zgabievi/.rvm/gems/ruby-2.3.0/gems/sass-3.4.22/lib/sass/stack.rb:79:in `block in with_base'
Expand Down Expand Up @@ -56,4 +85,4 @@ test.scss:2
body:before {
white-space: pre;
font-family: monospace;
content: "Error: File to import not found or unreadable: true.\A on line 2 of test.scss\A \A 1: @import \"../bem\";\A 2: @import \"true\";\A 3: \A 4: $true-terminal-output: true;\A 5: \A 6: @import \"functions\";\A 7: @import \"helpers\";"; }
content: "Error: sass-config package need to be imported before sass-bem package\A on line 36 of ../src/_config.scss\A from line 9 of ../_bem.scss\A from line 1 of test.scss"; }

0 comments on commit 371672d

Please sign in to comment.