Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove foundry import #60

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix: remove foundry import #60

merged 1 commit into from
Jun 11, 2024

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Jun 10, 2024

This import was added for convenience for Forge users, but apparently having this import requires you to have Forge CLI installed. If you don't have it, it throws an error.

Copy link

@GMaiolo GMaiolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@successaje
Copy link

Yea, faced similar error.
Remove Foundry import ✊

@fadeev fadeev merged commit c5ff2ff into main Jun 11, 2024
3 checks passed
@fadeev
Copy link
Member Author

fadeev commented Jun 11, 2024

I'm still keeping the foundry config so it's easier to use it with the template, but an import is something a developer would have to add manually. I don't think it makes sense to automate, because it's just one line.

Maybe I'll add it commented out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants