Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update protocol contracts repo to deploy bsc-mainnet #85

Conversation

andresaiello
Copy link
Collaborator

@andresaiello andresaiello commented Sep 29, 2023

Summary

  • Upgrade addresses and network version
  • Add support to bsc mainnet
  • Rename ethereum-mainnet to eth-mainnet for consistency with other repos
  • Remove unused code
  • Add etherscan to hardhat config to verify contracts on mainnet

@socket-security
Copy link

socket-security bot commented Sep 29, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@zetachain/addresses 0.0.9...0.0.13 None +0/-0 22.4 kB
@zetachain/networks 2.4.2...2.4.3 None +0/-0 26.3 kB lucasjanon

@andresaiello andresaiello marked this pull request as ready for review September 29, 2023 15:26
fadeev
fadeev previously approved these changes Oct 1, 2023
Copy link

@lucas-janon lucas-janon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

networks: {
...getHardhatConfigNetworks(PRIVATE_KEYS),
...getHardhatConfigNetworks(),
hardhat: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may no longer be necessary as getHardhatConfigNetworks should return hardhat by default.

https://github.com/zeta-chain/networks/blob/bcd8ff6ed7d752d39a024f5e2a983278c196814d/src/getHardhatConfigNetworks.ts#L16-L19

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove it in the next pr to not lose lucas approval and I need this pr

@andresaiello andresaiello merged commit 3bcfaa3 into main Oct 3, 2023
7 checks passed
@andresaiello andresaiello deleted the andy/pd-4735-update-protocol-contracts-repo-to-deploy-bsc-mainnet branch October 3, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants