Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deployment info for v21 implementation contract #434

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Dec 3, 2024

Contains the deployment info for the gateway and erc20Custody implementation contracts deployed for the authenticated call upgrade (v21)

Contains also a small fix in the simulate upgrade script

Summary by CodeRabbit

  • New Features

    • Added transaction records for the deployment of the GatewayEVM and ERC20Custody smart contracts using the CREATE2 opcode.
    • Introduced structured JSON files capturing transaction details, including sender and recipient addresses, gas limits, and input data for contract initialization.
  • Bug Fixes

    • Removed obsolete transaction records that were no longer needed.
  • Documentation

    • Enhanced metadata in transaction records for better tracking and verification of contract deployments.

Copy link
Contributor

coderabbitai bot commented Dec 3, 2024

📝 Walkthrough

Walkthrough

This pull request primarily involves the deletion of several JSON files that recorded transaction logs related to the deployment and interaction of the ERC20Custody and GatewayEVM smart contracts. Each deleted file documented transaction types (CREATE2 and CALL), contract addresses, sender and receiver details, gas limits, and input data. Additionally, new JSON files were introduced for the GatewayEVM contract, capturing similar transaction details, including deployment specifics and metadata.

Changes

File Path Change Summary
v2/broadcast/DeployERC20Custody.s.sol/1/dry-run/*.json Deleted multiple JSON files containing transaction logs for ERC20Custody and ERC1967Proxy deployments.
v2/broadcast/DeployERC20Custody.s.sol/137/dry-run/*.json Deleted multiple JSON files containing transaction logs for ERC20Custody and ERC1967Proxy deployments.
v2/broadcast/DeployERC20Custody.s.sol/56/dry-run/*.json Deleted multiple JSON files containing transaction logs for ERC20Custody and ERC1967Proxy deployments.
v2/broadcast/DeployERC20Custody.s.sol/8453/dry-run/*.json Deleted multiple JSON files containing transaction logs for ERC20Custody and ERC1967Proxy deployments.
v2/broadcast/DeployERC20CustodyImplementation.s.sol/1/*.json Added new JSON files documenting the deployment transactions for the ERC20Custody contract.
v2/broadcast/DeployERC20CustodyImplementation.s.sol/137/*.json Added new JSON files documenting the deployment transactions for the ERC20Custody contract.
v2/broadcast/DeployERC20CustodyImplementation.s.sol/56/*.json Added new JSON files documenting the deployment transactions for the ERC20Custody contract.
v2/broadcast/DeployGatewayEVM.s.sol/1/dry-run/*.json Deleted multiple JSON files containing transaction logs for GatewayEVM and ERC1967Proxy deployments.
v2/broadcast/DeployGatewayEVM.s.sol/137/dry-run/*.json Deleted multiple JSON files containing transaction logs for GatewayEVM and ERC1967Proxy deployments.
v2/broadcast/DeployGatewayEVM.s.sol/56/dry-run/*.json Deleted multiple JSON files containing transaction logs for GatewayEVM and ERC1967Proxy deployments.
v2/broadcast/DeployGatewayEVM.s.sol/8453/dry-run/*.json Deleted multiple JSON files containing transaction logs for GatewayEVM and ERC1967Proxy deployments.
v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/*.json Added new JSON files documenting the deployment transactions for the GatewayEVM contract.

Possibly related PRs

Suggested reviewers

  • fadeev
  • CharlieMc0
  • andresaiello
  • brewmaster012
  • skosito
  • fbac

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5368eb8 and e169ac8.

📒 Files selected for processing (34)
  • v2/broadcast/DeployERC20Custody.s.sol/1/dry-run/run-1730753291.json (0 hunks)
  • v2/broadcast/DeployERC20Custody.s.sol/1/dry-run/run-latest.json (0 hunks)
  • v2/broadcast/DeployERC20Custody.s.sol/137/dry-run/run-1730751736.json (0 hunks)
  • v2/broadcast/DeployERC20Custody.s.sol/137/dry-run/run-latest.json (0 hunks)
  • v2/broadcast/DeployERC20Custody.s.sol/56/dry-run/run-1730752569.json (0 hunks)
  • v2/broadcast/DeployERC20Custody.s.sol/56/dry-run/run-latest.json (0 hunks)
  • v2/broadcast/DeployERC20Custody.s.sol/8453/dry-run/run-1730737934.json (0 hunks)
  • v2/broadcast/DeployERC20Custody.s.sol/8453/dry-run/run-latest.json (0 hunks)
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/1/run-1733252238.json (1 hunks)
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/1/run-latest.json (1 hunks)
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/137/run-1733231885.json (1 hunks)
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/137/run-latest.json (1 hunks)
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/56/run-1733232160.json (1 hunks)
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/56/run-latest.json (1 hunks)
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/8453/run-1733231319.json (1 hunks)
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/8453/run-latest.json (1 hunks)
  • v2/broadcast/DeployGatewayEVM.s.sol/1/dry-run/run-1730753279.json (0 hunks)
  • v2/broadcast/DeployGatewayEVM.s.sol/1/dry-run/run-latest.json (0 hunks)
  • v2/broadcast/DeployGatewayEVM.s.sol/137/dry-run/run-1730751719.json (0 hunks)
  • v2/broadcast/DeployGatewayEVM.s.sol/137/dry-run/run-latest.json (0 hunks)
  • v2/broadcast/DeployGatewayEVM.s.sol/56/dry-run/run-1730752556.json (0 hunks)
  • v2/broadcast/DeployGatewayEVM.s.sol/56/dry-run/run-latest.json (0 hunks)
  • v2/broadcast/DeployGatewayEVM.s.sol/8453/dry-run/run-1730737910.json (0 hunks)
  • v2/broadcast/DeployGatewayEVM.s.sol/8453/dry-run/run-latest.json (0 hunks)
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733232295.json (1 hunks)
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733250991.json (1 hunks)
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733251007.json (1 hunks)
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733251017.json (1 hunks)
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733252189.json (1 hunks)
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733256946.json (1 hunks)
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733257136.json (1 hunks)
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733257161.json (1 hunks)
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733257244.json (1 hunks)
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733257433.json (1 hunks)
💤 Files with no reviewable changes (16)
  • v2/broadcast/DeployGatewayEVM.s.sol/56/dry-run/run-1730752556.json
  • v2/broadcast/DeployERC20Custody.s.sol/137/dry-run/run-latest.json
  • v2/broadcast/DeployERC20Custody.s.sol/1/dry-run/run-1730753291.json
  • v2/broadcast/DeployERC20Custody.s.sol/8453/dry-run/run-latest.json
  • v2/broadcast/DeployERC20Custody.s.sol/56/dry-run/run-latest.json
  • v2/broadcast/DeployGatewayEVM.s.sol/8453/dry-run/run-1730737910.json
  • v2/broadcast/DeployERC20Custody.s.sol/8453/dry-run/run-1730737934.json
  • v2/broadcast/DeployGatewayEVM.s.sol/56/dry-run/run-latest.json
  • v2/broadcast/DeployGatewayEVM.s.sol/8453/dry-run/run-latest.json
  • v2/broadcast/DeployERC20Custody.s.sol/56/dry-run/run-1730752569.json
  • v2/broadcast/DeployERC20Custody.s.sol/1/dry-run/run-latest.json
  • v2/broadcast/DeployGatewayEVM.s.sol/137/dry-run/run-1730751719.json
  • v2/broadcast/DeployGatewayEVM.s.sol/137/dry-run/run-latest.json
  • v2/broadcast/DeployERC20Custody.s.sol/137/dry-run/run-1730751736.json
  • v2/broadcast/DeployGatewayEVM.s.sol/1/dry-run/run-1730753279.json
  • v2/broadcast/DeployGatewayEVM.s.sol/1/dry-run/run-latest.json
✅ Files skipped from review due to trivial changes (18)
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/137/run-latest.json
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733256946.json
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/56/run-latest.json
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733232295.json
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733257161.json
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733257244.json
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733257433.json
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733257136.json
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/1/run-latest.json
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/56/run-1733232160.json
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/8453/run-latest.json
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733252189.json
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/137/run-1733231885.json
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733251007.json
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/8453/run-1733231319.json
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733251017.json
  • v2/broadcast/DeployGatewayEVMImplementation.s.sol/1/run-1733250991.json
  • v2/broadcast/DeployERC20CustodyImplementation.s.sol/1/run-1733252238.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.37%. Comparing base (5368eb8) to head (e169ac8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
+ Coverage   84.06%   86.37%   +2.31%     
==========================================
  Files           8        8              
  Lines         389      499     +110     
  Branches      124      124              
==========================================
+ Hits          327      431     +104     
- Misses         62       68       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumtis lumtis marked this pull request as ready for review December 5, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants