-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add DepositedAndCalled
and WithdrawnAndCalled
events
#403
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
47019ce
evm new event
lumtis 8f318f1
zevm new event=
lumtis 0f3b61e
generate
lumtis 6bd0335
add back original event names
lumtis ac24365
add back original event names for deposit
lumtis 965b125
fix tests
lumtis 69116fa
generate
lumtis dbe4e77
Merge branch 'main' into feat/new-events
skosito e74f50a
generate
skosito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,7 +32,7 @@ interface IGatewayEVMEvents { | |
/// @param receiver The address of the receiver. | ||
/// @param amount The amount of ETH or tokens deposited. | ||
/// @param asset The address of the ERC20 token (zero address if ETH). | ||
/// @param payload The calldata passed with the deposit. | ||
/// @param payload The calldata passed with the deposit. No longer used. Kept to maintain compatibility. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why we need to keep unused field? we have breaking interface in v21 for other things as well There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
/// @param revertOptions Revert options. | ||
event Deposited( | ||
address indexed sender, | ||
|
@@ -43,6 +43,22 @@ interface IGatewayEVMEvents { | |
RevertOptions revertOptions | ||
); | ||
|
||
/// @notice Emitted when a deposit and call is made. | ||
/// @param sender The address of the sender. | ||
/// @param receiver The address of the receiver. | ||
/// @param amount The amount of ETH or tokens deposited. | ||
/// @param asset The address of the ERC20 token (zero address if ETH). | ||
/// @param payload The calldata passed with the deposit. | ||
/// @param revertOptions Revert options. | ||
event DepositedAndCalled( | ||
address indexed sender, | ||
address indexed receiver, | ||
uint256 amount, | ||
address asset, | ||
bytes payload, | ||
RevertOptions revertOptions | ||
); | ||
|
||
/// @notice Emitted when an omnichain smart contract call is made without asset transfer. | ||
/// @param sender The address of the sender. | ||
/// @param receiver The address of the receiver. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,6 +58,9 @@ modifier onlyProtocol(); | |
|
||
### constructor | ||
|
||
**Note:** | ||
constructor | ||
|
||
|
||
```solidity | ||
constructor(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
v2/docs/src/contracts/zevm/interfaces/UniversalContract.sol/interface.zContract.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
v2/docs/src/contracts/zevm/interfaces/UniversalContract.sol/struct.zContext.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Clarify the deprecation of the
payload
parameter in theDeposited
eventThe comment for the
payload
parameter indicates it's "No longer used" but "Kept to maintain compatibility." To enhance clarity, consider marking this parameter as deprecated using a standard annotation or adding a clear deprecation notice. This will help developers understand that it should not be used in new implementations.