Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use nonReentrant only on functions interacting with arbitrary contracts #395

Merged
merged 6 commits into from
Oct 23, 2024
Merged

fix: use nonReentrant only on functions interacting with arbitrary contracts #395

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
acd0c41
remove non reentrant from execute methods
skosito Oct 16, 2024
17d9590
remove lib
skosito Oct 16, 2024
905691f
Merge branch 'main' into non-reentrant-fixes
skosito Oct 21, 2024
4df01e3
fix nonReentrant modifier usage
skosito Oct 21, 2024
39e72fe
cleanup
skosito Oct 23, 2024
36c6a2e
generate
skosito Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions v2/contracts/evm/GatewayEVM.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ contract GatewayEVM is
payable
onlyRole(TSS_ROLE)
whenNotPaused
nonReentrant
returns (bytes memory)
{
if (destination == address(0)) revert ZeroAddress();
Expand Down Expand Up @@ -186,7 +185,6 @@ contract GatewayEVM is
public
onlyRole(ASSET_HANDLER_ROLE)
whenNotPaused
nonReentrant
{
if (amount == 0) revert InsufficientERC20Amount();
if (to == address(0)) revert ZeroAddress();
Expand Down
Loading