-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: default to main branch for docs #392
Conversation
📝 WalkthroughWalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Script
participant MarkdownFiles
User->>Script: Execute generate_docs.sh
Script->>MarkdownFiles: Find all Markdown files
MarkdownFiles-->>Script: Return list of Markdown files
Script->>MarkdownFiles: Update URLs to main/v2/
Script->>Script: Remove .bak backup files
Script-->>User: Documentation generation complete
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (36)
📒 Files selected for processing (1)
🧰 Additional context used🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
=======================================
Coverage 84.95% 84.95%
=======================================
Files 8 8
Lines 412 412
Branches 138 138
=======================================
Hits 350 350
Misses 62 62 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
forge doc
outputs docs with a git commit hash in the URL, which is good, because it points to a specific version of a file. However, this makes it so that every time the docs are generated, the hash changes, so we can't reliably track if something has changed in the docs (we use this to automatically update protocol docs on the docs website).This PR updates the script to replace commit hash-based URLs with URLs pointing to
main
to ensure we can usegit diff
to check for changes in the docs.