feat: finalize nodev20 branch #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skosito
requested review from
andresaiello,
brewmaster012,
lumtis,
CharlieMc0,
fadeev and
fbac
as code owners
skosito
commented
Oct 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## node/v20.0.2 #388 +/- ##
===============================================
Coverage ? 83.19%
===============================================
Files ? 7
Lines ? 369
Branches ? 124
===============================================
Hits ? 307
Misses ? 61
Partials ? 1 ☔ View full report in Codecov by Sentry. |
lumtis
reviewed
Oct 15, 2024
lumtis
reviewed
Oct 15, 2024
fbac
approved these changes
Oct 16, 2024
J4X-98
reviewed
Oct 18, 2024
J4X-98
reviewed
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports and fixes listed in issue
relevant backports from these 2 PRs:
fix: add pauser role to tss #386
fix: review fixes #383
backport for onCrossChainCall rename: refactor: rename onCrosschainCall and zContext #349