Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove localnet from v2 #335

Merged
merged 1 commit into from
Aug 19, 2024
Merged

chore: remove localnet from v2 #335

merged 1 commit into from
Aug 19, 2024

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Aug 19, 2024

  • removing localnet from v2 folder since it's separate repo and no need to maintain on 2 places
  • remove not needed packages
  • add link to localnet repo in readme instead of v2/localnet

Summary by CodeRabbit

  • Documentation

    • Updated the link in the README to the V2 Localnet guide for improved accessibility.
  • Chores

    • Removed the localnet script and dependencies (concurrently, del-cli) from the project to streamline setup and reduce complexity.

Copy link
Contributor

coderabbitai bot commented Aug 19, 2024

Walkthrough

Walkthrough

The recent updates in Version 2 (V2) of the smart contract architecture focus on improving documentation accessibility and streamlining the development environment. Key changes include an updated link in the README file for easier navigation to the Localnet guide and the removal of certain scripts and dependencies in the package.json. These modifications aim to enhance user experience and simplify project setup.

Changes

File Change Summary
v2/README.md Updated the link to the V2 Localnet guide with an absolute URL for better accessibility; no other content changes made.
v2/package.json Removed the localnet script and dependencies on concurrently and del-cli, indicating a shift towards a simplified development setup and testing approach.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant README
    participant PackageManager

    Developer->>README: Access documentation
    README-->>Developer: Display updated link
    Developer->>PackageManager: Install dependencies
    PackageManager-->>Developer: Install remaining dependencies
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 100d765 and f8e161e.

Files ignored due to path filters (1)
  • v2/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing (2)
  • v2/README.md (1 hunks)
  • v2/package.json (2 hunks)
Files skipped from review due to trivial changes (2)
  • v2/README.md
  • v2/package.json

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.35%. Comparing base (100d765) to head (f8e161e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files           7        7           
  Lines         306      306           
  Branches       99       99           
=======================================
  Hits          252      252           
  Misses         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skosito skosito merged commit 9193cf9 into main Aug 19, 2024
9 checks passed
@skosito skosito deleted the remove-localnet branch August 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants