-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add instructions for deploy and verify #324
Conversation
WalkthroughThis update enhances the deployment script documentation by incorporating detailed instructions for contract verification after deployment. It introduces two verification methods— Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
v2/scripts/deploy/deterministic/readme.md (2)
31-33
: Specify the language for the code block.To improve readability and adhere to markdownlint guidelines, specify the language for the code block. For example, use
bash
for shell commands.- ``` + ```bashTools
Markdownlint
31-31: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
36-39
: Specify the language for the code block.To improve readability and adhere to markdownlint guidelines, specify the language for the code block. For example, use
bash
for shell commands.- ``` + ```bashTools
Markdownlint
36-36: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- v2/scripts/deploy/deterministic/readme.md (1 hunks)
Additional context used
Markdownlint
v2/scripts/deploy/deterministic/readme.md
31-31: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
36-36: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage 81.81% 81.81%
=======================================
Files 7 7
Lines 297 297
Branches 97 97
=======================================
Hits 243 243
Misses 54 54 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: PR semantic is docs instead of chore
closes: #252
tested on etherscan and blockscout explorers for sepolia network
Summary by CodeRabbit
etherscan
andblockscout
, complete with example commands for clarity.