chore(go.mod): revert go-ethereum version update
#260
Conversation
lumtis
requested review from
andresaiello,
brewmaster012,
CharlieMc0,
fadeev,
skosito and
fbac
as code owners
WalkthroughThe changes in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
===========================================
- Coverage 60.29% 49.13% -11.17%
===========================================
Files 16 16
Lines 403 403
Branches 108 108
===========================================
- Hits 243 198 -45
Misses 160 160
- Partials 0 45 +45 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (1)
- go.mod (1 hunks)
Additional comments not posted (4)
go.mod (4)
19-19: Verify the impact of replacingblstwithtestify.The addition of
testifyat versionv1.8.2replacingblstmight affect functionalities relying on the previous package.
17-17: Verify the impact of replacingaddchainwithnotify.The addition of
notifyat versionv0.9.1replacingaddchainmight affect functionalities relying on the previous package.Verification successful
No issues found with the replacement of
addchainwithnotify.The
notifypackage is referenced as an indirect dependency, and there are no direct usages of eithernotifyoraddchainin the codebase. Therefore, this change should not have a direct impact on the project's functionality.
- References to
notifyfound ingo.modandgo.sum.- No references to
addchainfound ingo.modandgo.sum.- No direct usages of
notifyoraddchainfound in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of replacing `addchain` with `notify` on the codebase. # Test: Search for usage of `notify` and `addchain` packages. Expect: No breaking changes due to replacement. rg --type go 'github.com/rjeczalik/notify' rg --type go 'github.com/mmcloughlin/addchain'Length of output: 89
Script:
#!/bin/bash # Description: Verify references to `notify` and `addchain` in go.mod and go.sum files, and check for indirect usages in the codebase. # Search for references to `notify` and `addchain` in go.mod and go.sum files. rg 'github.com/rjeczalik/notify' go.mod go.sum rg 'github.com/mmcloughlin/addchain' go.mod go.sum # Check for any indirect usages of `notify` and `addchain` in the codebase. rg --type go 'notify' -g '!go.mod' -g '!go.sum' rg --type go 'addchain' -g '!go.mod' -g '!go.sum'Length of output: 437
5-5: Verify the impact of downgradinggo-ethereum.The downgrade from
v1.13.5tov1.10.26might affect functionalities relying on features or fixes introduced in the later version.
10-10: Verify the impact of downgradinggolang-set.The downgrade from
v2.1.0tov1.8.0might affect functionalities relying on features or fixes introduced in the later version.
Revert change in 94d6e4e
Since
nodeusesv1.10.26, we need to stick to this version for now. Doesn't seem to affect anything in smart contracts in any case.Summary by CodeRabbit