-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: enable codecov for code coverage #186
Conversation
WalkthroughThe changes introduce a new GitHub Actions workflow for test coverage reporting and adjust existing workflows by altering triggers and dependencies. Specifically highlighted are updates for Solidity testing configurations and enhancements to the package.json scripts to improve coverage reporting and linting processes. Changes
Sequence Diagram(s)Not applicable for these changes. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (5)
- .github/workflows/coverage.yaml (1 hunks)
- .github/workflows/semantic-pr.yaml (1 hunks)
- .github/workflows/test.yaml (1 hunks)
- .solcover.js (1 hunks)
- package.json (2 hunks)
Files skipped from review due to trivial changes (4)
- .github/workflows/coverage.yaml
- .github/workflows/semantic-pr.yaml
- .github/workflows/test.yaml
- .solcover.js
Additional comments not posted (2)
package.json (2)
52-52
: Version update forsolidity-coverage
approved.Ensure to verify compatibility with other dependencies and existing project setups.
76-76
: Enhancement tocoverage
script looks good.Ensure the new
--temp
option functions as expected by running the coverage script.
Note: keeping a different action for regular test, and coverage, there is currently a non-blocking issue with ZetaConsumerEVM contract, where the regular test passes but not the coverage command. This keep test check and uploading coverage as two separate concerns.
Summary by CodeRabbit
New Features
Chores
solidity-coverage
version and adjusted related scripts inpackage.json
.