Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add onrevert to zevm connector #141

Merged
merged 6 commits into from
Apr 17, 2024
Merged

feat: Add onrevert to zevm connector #141

merged 6 commits into from
Apr 17, 2024

Conversation

andresaiello
Copy link
Collaborator

@andresaiello andresaiello commented Apr 10, 2024 •
edited
Loading

Summary

  • Add onrevert and extend onReceive
  • Deployed on Athens3 on 0xd2aA152341E19eEFf4baa2C704B0B56523a3812f

lumtis
lumtis reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add tests for the new functions in the same PR

contracts/zevm/ZetaConnectorZEVM.sol Outdated Show resolved Hide resolved
contracts/zevm/ZetaConnectorZEVM.sol Outdated Show resolved Hide resolved
contracts/zevm/ZetaConnectorZEVM.sol Outdated Show resolved Hide resolved
@lumtis lumtis requested a review from kingpinXD April 10, 2024 21:06
lumtis
lumtis reviewed Apr 12, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think we should include tests in the PR. Anything preventing this?

contracts/zevm/ZetaConnectorZEVM.sol Show resolved Hide resolved
lumtis
lumtis approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andresaiello andresaiello merged commit 4be6fd4 into main Apr 17, 2024
10 checks passed
@andresaiello andresaiello deleted the andy/pd-5976-add-onrevert-to-zevm-connecter-contract branch April 17, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingpinXD kingpinXD kingpinXD approved these changes

@lumtis lumtis lumtis approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@CharlieMc0 CharlieMc0 Awaiting requested review from CharlieMc0

@fadeev fadeev Awaiting requested review from fadeev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresaiello @lumtis @kingpinXD