Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Sepolia support #135

Merged
merged 7 commits into from
Mar 27, 2024
Merged

feat: Add Sepolia support #135

merged 7 commits into from
Mar 27, 2024

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Mar 19, 2024

Before merging

  • Merge Add Sepolia, remove Goerli networks#32
  • Release new version of networks (currently, using a pre-release version)
  • Add ZETA token consumer
  • Add Uniswap v2/v3 router addresses
  • Update networks package version in this branch

@fadeev
Copy link
Member Author

fadeev commented Mar 19, 2024

@andresaiello I need to know zetaTokenConsumerUniV2, uniswapV2Router02, uniswapV3Router for Sepolia. (these addresses cannot be fetched from chain).

andresaiello
andresaiello previously approved these changes Mar 25, 2024
@fadeev fadeev linked an issue Mar 26, 2024 that may be closed by this pull request
@fadeev
Copy link
Member Author

fadeev commented Mar 26, 2024

For Uniswap router contract address on Sepolia, I'm using the universal router from https://docs.uniswap.org/contracts/v3/reference/deployments

@fadeev fadeev requested a review from andresaiello March 26, 2024 04:32
@fadeev
Copy link
Member Author

fadeev commented Mar 26, 2024

I still don't know zeta token consumer address on Sepolia, which is needed for CCM, but I suppose we can add it later.

@fadeev
Copy link
Member Author

fadeev commented Mar 26, 2024

lumtis
lumtis previously approved these changes Mar 26, 2024
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses looks legit to me.

Wondering why do we store some addresses in duplicate in task/addresses?

@fadeev
Copy link
Member Author

fadeev commented Mar 26, 2024

@lumtis addresses in the tasks are the ones that we cannot fetch from anywhere.

@fadeev
Copy link
Member Author

fadeev commented Mar 26, 2024

Basically, these addresses are copied to the final JSON as is, the rest are fetched from chain/other contracts.

Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the Uniswapv3 address fix is out of the scope of the PR title but LGTM

@fadeev fadeev merged commit 485a869 into main Mar 27, 2024
10 checks passed
@fadeev fadeev deleted the sepolia branch March 27, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sepolia to addresses.json
3 participants