-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Sepolia support #135
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@zetachain/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected] |
@andresaiello I need to know |
For Uniswap router contract address on Sepolia, I'm using the universal router from https://docs.uniswap.org/contracts/v3/reference/deployments |
I still don't know zeta token consumer address on Sepolia, which is needed for CCM, but I suppose we can add it later. |
Is this the consumer address? https://sepolia.etherscan.io/address/0x7e792f3736751e168864106AdbAC50152641A927 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addresses looks legit to me.
Wondering why do we store some addresses in duplicate in task/addresses
?
@lumtis addresses in the tasks are the ones that we cannot fetch from anywhere. |
Basically, these addresses are copied to the final JSON as is, the rest are fetched from chain/other contracts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the Uniswapv3 address fix is out of the scope of the PR title but LGTM
Before merging