fix: address warnings in build (#399)

zeta-chain · Oct 17, 2024 · ff64066 · ff64066
1 parent db2f95f
commit ff64066
Show file tree

Hide file tree

Showing 38 changed files with 185 additions and 192 deletions.
diff --git a/v2/contracts/evm/ZetaConnectorNative.sol b/v2/contracts/evm/ZetaConnectorNative.sol
@@ -27,12 +27,13 @@ contract ZetaConnectorNative is ZetaConnectorBase {
     /// @notice Withdraw tokens to a specified address.
     /// @param to The address to withdraw tokens to.
     /// @param amount The amount of tokens to withdraw.
-    /// @param internalSendHash A hash used for internal tracking of the transaction.
+    //// @param internalSendHash A hash used for internal tracking of the transaction (not used currently
+    // https://github.com/zeta-chain/protocol-contracts/issues/398)
     /// @dev This function can only be called by the TSS address.
     function withdraw(
         address to,
         uint256 amount,
-        bytes32 internalSendHash
+        bytes32 /*internalSendHash*/
     )
         external
         override
@@ -48,13 +49,14 @@ contract ZetaConnectorNative is ZetaConnectorBase {
     /// @param to The address to withdraw tokens to.
     /// @param amount The amount of tokens to withdraw.
     /// @param data The calldata to pass to the contract call.
-    /// @param internalSendHash A hash used for internal tracking of the transaction.
+    //// @param internalSendHash A hash used for internal tracking of the transaction (not used currently
+    // https://github.com/zeta-chain/protocol-contracts/issues/398)
     /// @dev This function can only be called by the TSS address.
     function withdrawAndCall(
         address to,
         uint256 amount,
         bytes calldata data,
-        bytes32 internalSendHash
+        bytes32 /*internalSendHash*/
     )
         external
         override
@@ -75,14 +77,15 @@ contract ZetaConnectorNative is ZetaConnectorBase {
     /// @param to The address to withdraw tokens to.
     /// @param amount The amount of tokens to withdraw.
     /// @param data The calldata to pass to the contract call.
-    /// @param internalSendHash A hash used for internal tracking of the transaction.
+    //// @param internalSendHash A hash used for internal tracking of the transaction (not used currently
+    // https://github.com/zeta-chain/protocol-contracts/issues/398)
     /// @dev This function can only be called by the TSS address.
     /// @param revertContext Revert context to pass to onRevert.
     function withdrawAndRevert(
         address to,
         uint256 amount,
         bytes calldata data,
-        bytes32 internalSendHash,
+        bytes32, /*internalSendHash*/
         RevertContext calldata revertContext
     )
         external

diff --git a/v2/docs/src/contracts/evm/ERC20Custody.sol/contract.ERC20Custody.md b/v2/docs/src/contracts/evm/ERC20Custody.sol/contract.ERC20Custody.md
@@ -264,6 +264,9 @@ function withdrawAndRevert(
 
 Deposits asset to custody and pay fee in zeta erc20.
 
+**Note:**
+This method is deprecated.
+
 
 ```solidity
 function deposit(

diff --git a/v2/docs/src/contracts/evm/GatewayEVM.sol/contract.GatewayEVM.md b/v2/docs/src/contracts/evm/GatewayEVM.sol/contract.GatewayEVM.md
@@ -85,6 +85,9 @@ uint256 public constant MAX_PAYLOAD_SIZE = 1024;
 ## Functions
 ### constructor
 
+**Note:**
+constructor
+
 
 ```solidity
 constructor();

diff --git a/v2/docs/src/contracts/evm/ZetaConnectorNative.sol/contract.ZetaConnectorNative.md b/v2/docs/src/contracts/evm/ZetaConnectorNative.sol/contract.ZetaConnectorNative.md
@@ -36,7 +36,7 @@ Withdraw tokens to a specified address.
 function withdraw(
     address to,
     uint256 amount,
-    bytes32 internalSendHash
+    bytes32
 )
     external
     override
@@ -50,7 +50,7 @@ function withdraw(
 |----|----|-----------|
 |`to`|`address`|The address to withdraw tokens to.|
 |`amount`|`uint256`|The amount of tokens to withdraw.|
-|`internalSendHash`|`bytes32`|A hash used for internal tracking of the transaction.|
+|`<none>`|`bytes32`||
 
 
 ### withdrawAndCall
@@ -65,7 +65,7 @@ function withdrawAndCall(
     address to,
     uint256 amount,
     bytes calldata data,
-    bytes32 internalSendHash
+    bytes32
 )
     external
     override
@@ -80,7 +80,7 @@ function withdrawAndCall(
 |`to`|`address`|The address to withdraw tokens to.|
 |`amount`|`uint256`|The amount of tokens to withdraw.|
 |`data`|`bytes`|The calldata to pass to the contract call.|
-|`internalSendHash`|`bytes32`|A hash used for internal tracking of the transaction.|
+|`<none>`|`bytes32`||
 
 
 ### withdrawAndRevert
@@ -95,7 +95,7 @@ function withdrawAndRevert(
     address to,
     uint256 amount,
     bytes calldata data,
-    bytes32 internalSendHash,
+    bytes32,
     RevertContext calldata revertContext
 )
     external
@@ -111,7 +111,7 @@ function withdrawAndRevert(
 |`to`|`address`|The address to withdraw tokens to.|
 |`amount`|`uint256`|The amount of tokens to withdraw.|
 |`data`|`bytes`|The calldata to pass to the contract call.|
-|`internalSendHash`|`bytes32`|A hash used for internal tracking of the transaction.|
+|`<none>`|`bytes32`||
 |`revertContext`|`RevertContext`|Revert context to pass to onRevert.|
 
 

diff --git a/v2/docs/src/contracts/zevm/GatewayZEVM.sol/contract.GatewayZEVM.md b/v2/docs/src/contracts/zevm/GatewayZEVM.sol/contract.GatewayZEVM.md
@@ -58,6 +58,9 @@ modifier onlyProtocol();
 
 ### constructor
 
+**Note:**
+constructor
+
 
 ```solidity
 constructor();

diff --git a/v2/docs/src/contracts/zevm/interfaces/UniversalContract.sol/interface.zContract.md b/v2/docs/src/contracts/zevm/interfaces/UniversalContract.sol/interface.zContract.md
@@ -1,6 +1,10 @@
 # zContract
 [Git Source](https://github.com/zeta-chain/protocol-contracts/blob/main/v2/contracts/zevm/interfaces/UniversalContract.sol)
 
+**Note:**
+should be removed once v2 SystemContract is not used anymore.
+UniversalContract should be used
+
 
 ## Functions
 ### onCrossChainCall

diff --git a/v2/docs/src/contracts/zevm/interfaces/UniversalContract.sol/struct.zContext.md b/v2/docs/src/contracts/zevm/interfaces/UniversalContract.sol/struct.zContext.md
@@ -1,6 +1,10 @@
 # zContext
 [Git Source](https://github.com/zeta-chain/protocol-contracts/blob/main/v2/contracts/zevm/interfaces/UniversalContract.sol)
 
+**Note:**
+should be removed once v2 SystemContract is not used anymore.
+MessageContext should be used
+
 
 ```solidity
 struct zContext {

diff --git a/v2/foundry.toml b/v2/foundry.toml
@@ -13,6 +13,7 @@ remappings = [
   "@openzeppelin/contracts-upgradeable/=node_modules/@openzeppelin/contracts-upgradeable/"
 ]
 
+solc-version = "0.8.26"
 no-match-contract = '.*EchidnaTest$'
 optimizer = true
 optimizer_runs = 10_000

diff --git a/v2/pkg/erc20custody.t.sol/erc20custodytest.go b/v2/pkg/erc20custody.t.sol/erc20custodytest.go
diff --git a/v2/pkg/gatewayevm.t.sol/gatewayevminboundtest.go b/v2/pkg/gatewayevm.t.sol/gatewayevminboundtest.go
diff --git a/v2/pkg/gatewayevm.t.sol/gatewayevmtest.go b/v2/pkg/gatewayevm.t.sol/gatewayevmtest.go
diff --git a/v2/pkg/gatewayevmzevm.t.sol/gatewayevmzevmtest.go b/v2/pkg/gatewayevmzevm.t.sol/gatewayevmzevmtest.go
diff --git a/v2/pkg/gatewayzevm.t.sol/gatewayzevminboundtest.go b/v2/pkg/gatewayzevm.t.sol/gatewayzevminboundtest.go
diff --git a/v2/pkg/gatewayzevm.t.sol/gatewayzevmoutboundtest.go b/v2/pkg/gatewayzevm.t.sol/gatewayzevmoutboundtest.go
diff --git a/v2/pkg/receiverevm.sol/receiverevm.go b/v2/pkg/receiverevm.sol/receiverevm.go
diff --git a/v2/pkg/testuniversalcontract.sol/testuniversalcontract.go b/v2/pkg/testuniversalcontract.sol/testuniversalcontract.go