add more checks to withdraw function

zeta-chain · Jul 3, 2024 · efd62ce · efd62ce
1 parent 725da8e
commit efd62ce
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/contracts/prototypes/zevm/GatewayZEVM.sol b/contracts/prototypes/zevm/GatewayZEVM.sol
@@ -14,6 +14,8 @@ contract GatewayZEVM is Initializable, OwnableUpgradeable, UUPSUpgradeable {
 
     error WithdrawalFailed();
     error InsufficientZRC20Amount();
+    error ZRC20BurnFailed();
+    error ZRC20TransferFailed();
     error GasFeeTransferFailed();
     error CallerIsNotFungibleModule();
     error InvalidTarget();
@@ -39,8 +41,11 @@ contract GatewayZEVM is Initializable, OwnableUpgradeable, UUPSUpgradeable {
             revert GasFeeTransferFailed();
         }
 
-        IZRC20(zrc20).transferFrom(msg.sender, address(this), amount);
-        IZRC20(zrc20).burn(amount);
+        if (!IZRC20(zrc20).transferFrom(msg.sender, address(this), amount)) {
+            revert ZRC20TransferFailed();
+        }
+
+        if (!IZRC20(zrc20).burn(amount)) revert ZRC20BurnFailed();
 
         return gasFee;
     }