Skip to content

Commit

Permalink
ci: slither ignore foundry compilation (#221)
Browse files Browse the repository at this point in the history
Signed-off-by: Francisco de Borja Aranda Castillejo <[email protected]>
Co-authored-by: skosito <[email protected]>
  • Loading branch information
Francisco de Borja Aranda Castillejo and skosito authored Jul 12, 2024
1 parent 961c059 commit 180b8c8
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 19 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/slither.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,19 +33,19 @@ jobs:

- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
- name: Install Dependencies

- name: Install dependencies
run: yarn install

- name: Compile contracts
run: yarn compile
- name: Build project
run: yarn build

- name: Run Slither
uses: crytic/slither-action@main
id: slither
continue-on-error: true
with:
sarif: results.sarifs
sarif: results.sarif
node-version: "18"
fail-on: none

Expand Down
14 changes: 4 additions & 10 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: "18"
node-version: "20"
registry-url: "https://registry.npmjs.org"

- name: Install Foundry
Expand All @@ -35,14 +35,8 @@ jobs:
- name: Install Dependencies
run: yarn install

- name: Build project
run: yarn build

- name: Test (hardhat)
run: yarn test

- name: Test v2 (hardhat)
run: yarn test:prototypes

- name: Test v2 (forge)
run: yarn test:forge



5 changes: 1 addition & 4 deletions slither.config.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
{
"compile_force_framework": "hardhat",
"detectors_to_exclude": "",
"filter_paths": "artifacts,cache,data,dist,docs,lib,node_modules,pkg,scripts,tasks,test,testing,typechain-types",
"hardhat_ignore_compile": true,
"npx_disable": true
"filter_paths": "forge-std,artifacts,cache,data,dist,docs,lib,node_modules,pkg,scripts,tasks,test,testing,typechain-types"
}

0 comments on commit 180b8c8

Please sign in to comment.