Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: initialize rust ci #11

Merged
merged 7 commits into from
Aug 7, 2024
Merged

ci: initialize rust ci #11

merged 7 commits into from
Aug 7, 2024

Conversation

fbac
Copy link
Contributor

@fbac fbac commented Aug 7, 2024

Closes #8

Introduces:

  • CODEOWNERS file.
  • Formatting script leveraging cargo fmt.
    • Discussion: current script uses brew to install rustfmt. We could be using rustup too, the script should check whether brew or rustup are available on the host.
  • .gitignore with all the current paths needed to ignore.
  • Check workflow: format, clippy, doc and hack. Based on the standard set by OpenZeppelin.
  • Coverage workflow.
  • nostd workflow: code should be able to run without rust std.
  • Test workflow.

@fbac fbac marked this pull request as ready for review August 7, 2024 13:18
@lumtis
Copy link
Member

lumtis commented Aug 7, 2024

Added the CODECOV_TOKEN

Copy link
Collaborator

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@fbac fbac merged commit eb03529 into main Aug 7, 2024
13 checks passed
@fbac fbac deleted the initialize-ci branch August 7, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize CI with Github action
4 participants