Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: backport solana performance tests and performance improvements #3298

Open
wants to merge 6 commits into
base: release/v23
Choose a base branch
from

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Dec 16, 2024

Description

backport of solana e2e performance tests and performance improvements: #3276

How Has This Been Tested?

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

…erformance (#3276)

* stress tests deposit solana

* perf tests for sol withdrawals

* split withdrawal stress tests into separate tests

* separate deposit stress tests

* add restart always to solana container

* tweak params

* fmt and changelog

* cleanup

* making tests execution more granular

* revert last change

* split perf tests

* tweak params

* decrease num of withdrawals back to 30

* run only withdrawals

* run sequentiallyx

* uncomment tests

* params

* fix: speed up Solana withdraw stress test in two go routines (#3295)

* PR comment and lint

* changelog

* move account info decoding to solana package

* revert timeouts to prev values

---------

Co-authored-by: Charlie Chen <[email protected]>
@skosito skosito added no-changelog Skip changelog CI check SOLANA_TESTS Run make start-solana-test PERFORMANCE_TESTS Run make start-e2e-performance-test labels Dec 16, 2024
Copy link
Contributor

coderabbitai bot commented Dec 16, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 69 lines in your changes missing coverage. Please review.

Project coverage is 62.60%. Comparing base (cf747df) to head (b84b787).

Files with missing lines Patch % Lines
zetaclient/chains/solana/signer/signer.go 0.00% 45 Missing ⚠️
pkg/contracts/solana/account_info.go 0.00% 16 Missing ⚠️
zetaclient/orchestrator/orchestrator.go 0.00% 7 Missing ⚠️
.../chains/solana/signer/outbound_tracker_reporter.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release/v23    #3298      +/-   ##
===============================================
- Coverage        62.69%   62.60%   -0.09%     
===============================================
  Files              425      426       +1     
  Lines            30348    30391      +43     
===============================================
  Hits             19027    19027              
- Misses           10475    10518      +43     
  Partials           846      846              
Files with missing lines Coverage Δ
.../chains/solana/signer/outbound_tracker_reporter.go 0.00% <0.00%> (ø)
zetaclient/orchestrator/orchestrator.go 18.27% <0.00%> (-0.22%) ⬇️
pkg/contracts/solana/account_info.go 0.00% <0.00%> (ø)
zetaclient/chains/solana/signer/signer.go 21.37% <0.00%> (-1.87%) ⬇️

@gartnera
Copy link
Member

The performance tests are broken on the v23 branch. I think you could pull in #3277 to fix them.

gartnera and others added 3 commits December 16, 2024 17:21
* refactor(e2e): use seed address book rather than bootstrap peer

* review updates

* move to local

* feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:cli no-changelog Skip changelog CI check PERFORMANCE_TESTS Run make start-e2e-performance-test SOLANA_TESTS Run make start-solana-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants