Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the ZEVM address pulled from memo as Receiver in MsgVoteInbound #3267

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Dec 10, 2024

Description

backporting original PR: #3242

How Has This Been Tested?

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

…und (#3242)

* use the ZEVM address decoded from memo as Receiver in MsgVoteInbound

* add Receiver check in unit test

* add changelog entry

* fix unit test
Copy link
Contributor

coderabbitai bot commented Dec 10, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@skosito skosito added no-changelog Skip changelog CI check SOLANA_TESTS Run make start-solana-test labels Dec 10, 2024
@lumtis
Copy link
Member

lumtis commented Dec 10, 2024

Test failing @skosito

@skosito
Copy link
Contributor Author

skosito commented Dec 10, 2024

Test failing @skosito

fixed, had to get one part from https://github.com/zeta-chain/node/pull/3184/files#diff-6a92b255eec768ddb5bbcec4177b51c19e6aab507aeff71868d464d659c89fd0

i backported that in this commit dfaa7af

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 51.72414% with 14 lines in your changes missing coverage. Please review.

Project coverage is 62.69%. Comparing base (2ca464a) to head (5c1a95d).
Report is 1 commits behind head on release/v23.

Files with missing lines Patch % Lines
zetaclient/types/event.go 40.00% 6 Missing and 3 partials ⚠️
zetaclient/chains/solana/observer/inbound.go 64.28% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release/v23    #3267      +/-   ##
===============================================
- Coverage        62.70%   62.69%   -0.02%     
===============================================
  Files              424      425       +1     
  Lines            30322    30348      +26     
===============================================
+ Hits             19014    19027      +13     
- Misses           10466    10475       +9     
- Partials           842      846       +4     
Files with missing lines Coverage Δ
zetaclient/chains/solana/observer/inbound.go 32.87% <64.28%> (+1.62%) ⬆️
zetaclient/types/event.go 40.00% <40.00%> (ø)

@skosito skosito marked this pull request as draft December 12, 2024 01:57
@skosito skosito marked this pull request as ready for review December 12, 2024 02:17
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skosito skosito closed this Dec 16, 2024
@skosito skosito reopened this Dec 16, 2024
@skosito skosito enabled auto-merge (squash) December 16, 2024 12:33
@skosito skosito merged commit cf747df into release/v23 Dec 16, 2024
43 of 44 checks passed
@skosito skosito deleted the backport-receiver-solana-fix branch December 16, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Skip changelog CI check SOLANA_TESTS Run make start-solana-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants