-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use the ZEVM address pulled from memo as Receiver in MsgVoteInbound #3267
Conversation
…und (#3242) * use the ZEVM address decoded from memo as Receiver in MsgVoteInbound * add Receiver check in unit test * add changelog entry * fix unit test
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Test failing @skosito |
fixed, had to get one part from https://github.com/zeta-chain/node/pull/3184/files#diff-6a92b255eec768ddb5bbcec4177b51c19e6aab507aeff71868d464d659c89fd0 i backported that in this commit dfaa7af |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v23 #3267 +/- ##
===============================================
- Coverage 62.70% 62.69% -0.02%
===============================================
Files 424 425 +1
Lines 30322 30348 +26
===============================================
+ Hits 19014 19027 +13
- Misses 10466 10475 +9
- Partials 842 846 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
backporting original PR: #3242
How Has This Been Tested?