fix: use different database file names for signet and testnet4 to avoid wrong height

[ws4charlie]

Description

The zetaclients in the Testnet are pulling last scanned height from wrong database file btc_chain_client which was intended only for testnet3 and mainnet. The testnet3 block number is much higher than current signet block, the inbound observation will stop because no block will be treated as confirmed. See this logic

Closes #3223

How Has This Been Tested?

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.65%. Comparing base (a87243a) to head (f10949c).
Report is 1 commits behind head on release/v23.

Files with missing lines	Patch %	Lines
zetaclient/config/types.go	57.14%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           release/v23    #3224   +/-   ##
============================================
  Coverage        62.64%   62.65%           
============================================
  Files              424      424           
  Lines            30243    30259   +16     
============================================
+ Hits             18946    18959   +13     
- Misses           10457    10459    +2     
- Partials           840      841    +1     

Files with missing lines	Coverage Δ
zetaclient/orchestrator/bootstrap.go	59.05% <100.00%> (+1.38%)	⬆️
zetaclient/config/types.go	49.38% <57.14%> (-0.62%)	⬇️

[gartnera]

{"level":"info","chain":18333,"chain_network":"btc","module":"inbound","time":"2024-11-26T21:37:02Z","message":"observeInboundBTC: block 223762 has 68 txs, current block 223764, last scanned 223761"}

48879|2024-11-26 21:37:02.916601526+00:00|2024-11-26 21:37:02.916446964+00:00||223762

Looks good during our testnet run

[lumtis]

Please refer to my review in #3225

[swift1337]

Please refer to my review in #3225

Same :)