Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(zetaclient)!: remove hsm signer #3118

Merged
merged 3 commits into from
Nov 6, 2024

changelog

775c1f5
Select commit
Loading
Failed to load commit list.
Merged

refactor(zetaclient)!: remove hsm signer #3118

changelog
775c1f5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 6, 2024 in 0s

63.54% (+0.24%) compared to a1fe36d

View this Pull Request on Codecov

63.54% (+0.24%) compared to a1fe36d

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.54%. Comparing base (a1fe36d) to head (775c1f5).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3118      +/-   ##
===========================================
+ Coverage    63.30%   63.54%   +0.24%     
===========================================
  Files          422      421       -1     
  Lines        29954    29838     -116     
===========================================
- Hits         18963    18962       -1     
+ Misses       10150    10036     -114     
+ Partials       841      840       -1     
Files with missing lines Coverage Δ
zetaclient/config/types.go 50.00% <ø> (ø)
zetaclient/zetacore/broadcast.go 58.82% <100.00%> (+1.44%) ⬆️
zetaclient/zetacore/client.go 52.80% <ø> (-0.19%) ⬇️