-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix changelog for v21 #3052
Conversation
📝 WalkthroughWalkthroughThe pull request introduces version Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (5)
changelog.md (5)
5-6
: Consider adding release date.The version entry should include the release date for better tracking and historical reference.
## v21.0.0 +Released: 2024-10-XX
Line range hint
8-25
: Standardize feature entry format and add impact descriptions.Some feature entries lack context about their impact on the system. Consider standardizing the format to include:
- What changed
- Why it changed
- Impact on users/system
Example format for the first entry:
-* [2633](https://github.com/zeta-chain/node/pull/2633) - support for stateful precompiled contracts +* [2633](https://github.com/zeta-chain/node/pull/2633) - Added support for stateful precompiled contracts to enable persistent state management in precompiled contracts, improving contract functionality and state handling.
Line range hint
27-34
: Standardize refactor entry format and ensure consistent punctuation.The refactor entries have inconsistent punctuation and varying levels of detail.
Example format:
-* [2749](https://github.com/zeta-chain/node/pull/2749) - fix all lint errors from govet +* [2749](https://github.com/zeta-chain/node/pull/2749) - Fixed all lint errors from govet to improve code quality.
Line range hint
36-45
: Add test coverage information.Test entries should include information about the coverage impact and testing scope.
Example format:
-* [2703](https://github.com/zeta-chain/node/pull/2703) - add e2e tests for stateful precompiled contracts +* [2703](https://github.com/zeta-chain/node/pull/2703) - Added e2e tests for stateful precompiled contracts, achieving X% coverage for the precompiled contracts functionality.
Line range hint
47-57
: Add severity levels to fixes.Fix entries should indicate the severity level and potential impact of the fix.
Example format:
-* [2674](https://github.com/zeta-chain/node/pull/2674) - allow operators to vote on ballots associated with discarded keygen without affecting the status of the current keygen. +* [2674](https://github.com/zeta-chain/node/pull/2674) - [High] Fixed keygen voting issue: Allowed operators to vote on ballots associated with discarded keygen without affecting current keygen status, preventing potential voting deadlocks.
Description
Add v21 in changelog (to be pushed in release branch as well)
Summary by CodeRabbit
New Features
zetacored
RPC package.Bug Fixes
Refactor
Tests