test: simulation import and export

.github/workflows/simulation-test.yaml

@@ -0,0 +1,75 @@
+name: Simulation Tests Workflow
+
+on:
+#  # The workflow runs when code is pushed to either the main or develop branches
+#  push:
+#    branches:
+#      - main
+#      - develop
+#  # The workflow runs when a pull request is opened or updated
+#  pull_request:
+#  # Run daily at 6AM UTC Daily
+#  schedule:
+#    - cron: "0 6 * * *"
+#  # It can be run manually targetting a specific test
+  workflow_dispatch:
+    inputs:
+      test-target:
+        description: 'Makefile test target to run (e.g., test-sim-nondeterminism)'
+        required: true
+        default: 'test-sim-fullappsimulation'
+
+concurrency:
+  # Ensures that only one run of this workflow is active per branch or commit
+  group: runsim-${{ github.head_ref || github.sha }}
+  # If a new run is triggered for the same branch/commit while an old one is still in progress, the previous run will be canceled
+  cancel-in-progress: true
+
+jobs:
+  # This job is responsible for setting up the environment and installing the necessary dependencies, including runsim
+  install-dependencies:
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Set up Go
+        uses: actions/setup-go@v4
+        with:
+          go-version: '1.20'
+
+      - name: Install runsim and dependencies
+        run: |
+          make runsim
+
+  run-simulation-tests:
+    needs: install-dependencies
+    runs-on: ubuntu-22.04
+    strategy:
+      matrix:
+        # The matrix strategy allows running multiple simulation tests in parallel. In this case, it runs the following targets from the Makefile
+        test-target: [
+          "test-sim-nondeterminism",
+          "test-sim-fullappsimulation",
+          "test-sim-import-export",
+          "test-sim-after-import"
+        ]
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      # It runs the specified test from the Makefile by calling make ${{ matrix.test-target }}, where test-target is one of the matrix values
+      - name: Run Simulation Test - ${{ matrix.test-target }}
+        run: |
+          make ${{ matrix.test-target }}
+
+  manual-run:
+    runs-on: ubuntu-22.04
+    if: github.event_name == 'workflow_dispatch'
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+      # This job only runs if the workflow was triggered by a manual dispatch (workflow_dispatch)
+      - name: Run Simulation Test - ${{ github.event.inputs.test-target }}
+        run: |
+          make ${{ github.event.inputs.test-target }}

Makefile

@@ -381,17 +381,23 @@ $(BINDIR)/runsim:
 # Period: Invariant check period
 # Timeout: Timeout for the simulation test
 define run-sim-test
-	@echo "Running $(1)..."
+	@echo "Running $(1)"
 	@go test -mod=readonly $(SIMAPP) -run $(2) -Enabled=true \
 		-NumBlocks=$(3) -BlockSize=$(4) -Commit=true -Period=0 -v -timeout $(5)
 endef
 
 test-sim-nondeterminism:
-	$(call run-sim-test,"non-determinism test",TestAppStateDeterminism,100,200,2h)
+	$(call run-sim-test,"non-determinism test",TestAppStateDeterminism,10,20,2h)
 
 test-sim-fullappsimulation:
 	$(call run-sim-test,"TestFullAppSimulation",TestFullAppSimulation,100,200,2h)
 
+test-sim-import-export:
+	$(call run-sim-test,"test-import-export",TestAppImportExport,10,20,2h)
+
+test-sim-after-import:
+	$(call run-sim-test,"test-sim-after-import",TestAppSimulationAfterImport,10,20,2h)
+
 test-sim-multi-seed-long: runsim
 	@echo "Running long multi-seed application simulation."
 	@$(BINDIR)/runsim -Jobs=4 -SimAppPkg=$(SIMAPP) -ExitOnFail 500 50 TestFullAppSimulation
@@ -400,13 +406,23 @@ test-sim-multi-seed-short: runsim
 	@echo "Running short multi-seed application simulation."
 	@$(BINDIR)/runsim -Jobs=4 -SimAppPkg=$(SIMAPP) -ExitOnFail 50 10 TestFullAppSimulation
 
+test-sim-import-export-long: runsim
+	@echo "Running application import/export simulation. This may take several minutes"
+	@$(BINDIR)/runsim -Jobs=4 -SimAppPkg=$(SIMAPP) -ExitOnFail 50 5 TestAppImportExport
 
+test-sim-after-import-long: runsim
+	@echo "Running application simulation-after-import. This may take several minute"
+	@$(BINDIR)/runsim -Jobs=4 -SimAppPkg=$(SIMAPP) -ExitOnFail 50 5 TestAppSimulationAfterImport
 
 .PHONY: \
 test-sim-nondeterminism \
 test-sim-fullappsimulation \
 test-sim-multi-seed-long \
-test-sim-multi-seed-short
+test-sim-multi-seed-short \
+test-sim-import-export \
+test-sim-after-import \
+test-sim-import-export-long \
+test-sim-after-import-long
 
 
 ###############################################################################

app/app.go

@@ -1060,6 +1060,10 @@ func (app *App) BasicManager() module.BasicManager {
 	return app.mb
 }
 
+func (app *App) ModuleManager() *module.Manager {
+	return app.mm
+}
+
 func (app *App) BlockedAddrs() map[string]bool {
 	blockList := make(map[string]bool)
 

app/export.go

@@ -75,10 +75,7 @@ func (app *App) prepForZeroHeightGenesis(ctx sdk.Context, jailAllowedAddrs []str
 
 	// withdraw all validator commission
 	app.StakingKeeper.IterateValidators(ctx, func(_ int64, val stakingtypes.ValidatorI) (stop bool) {
-		_, err := app.DistrKeeper.WithdrawValidatorCommission(ctx, val.GetOperator())
-		if err != nil {
-			panic(err)
-		}
+		_, _ = app.DistrKeeper.WithdrawValidatorCommission(ctx, val.GetOperator())
 		return false
 	})
 
@@ -162,7 +159,7 @@ func (app *App) prepForZeroHeightGenesis(ctx sdk.Context, jailAllowedAddrs []str
 	counter := int16(0)
 
 	for ; iter.Valid(); iter.Next() {
-		addr := sdk.ValAddress(iter.Key()[1:])
+		addr := sdk.ValAddress(iter.Key()[2:])
 		validator, found := app.StakingKeeper.GetValidator(ctx, addr)
 		if !found {
 			panic("expected validator, not found")

changelog.md

@@ -44,6 +44,7 @@
 * [2894](https://github.com/zeta-chain/node/pull/2894) - increase gas limit for TSS vote tx
 * [2932](https://github.com/zeta-chain/node/pull/2932) - add gateway upgrade as part of the upgrade test
 * [2947](https://github.com/zeta-chain/node/pull/2947) - initialize simulation tests
+* [3033](https://github.com/zeta-chain/node/pull/3033) - initialize simulation tests for import and export
 
 ### Fixes
 

docs/development/SIMULATION_TESTING.md

@@ -20,15 +20,38 @@ At the end of the run it tries to export the genesis state to make sure the expo
 ```bash
 make test-sim-full-app
 ```
-
+### Import Export simulation test
+The import export simulation test runs a full application simulation
+and exports the application state at the end of the run.
+This state is then then imported into a new simulation.
+At the end of the run we compare the keys for the application state for both the simulations
+to make sure they are the same.
+```bash
+make test-sim-import-export
+```
+### Import and run simulation test
+This simulation test exports the application state at the end of the run and imports it into a new simulation.
+```bash
+make test-sim-import-export
+```
 ### Multi seed long test
 Multi seed long test runs a full application simulation with multiple seeds and multiple blocks.This runs the test for a longer duration compared to the multi seed short test
 ```bash
 make test-sim-multi-seed-long
 ```
-
 ### Multi seed short test
 Multi seed short test runs a full application simulation with multiple seeds and multiple blocks. This runs the test for a longer duration compared to the multi seed long test
 ```bash
 make test-sim-multi-seed-short
-```
+```
+### Import Export long test
+This test runs the import export simulation test for a longer duration.It uses the runsim tool to run the same test in parallel threads
+```bash
+make test-sim-import-export-long
+```
+### Import and run simulation test
+This test runs the import and run simulation test for a longer duration. It uses the runsim tool to run the same test in parallel threads
+```bash
+make test-sim-after-import-longg
+```
+

tests/simulation/sim/sim_utils.go

@@ -1,12 +1,16 @@
 package sim
 
 import (
+	"encoding/json"
 	"fmt"
+	"os"
 
 	dbm "github.com/cometbft/cometbft-db"
 	"github.com/cometbft/cometbft/libs/log"
 	"github.com/cosmos/cosmos-sdk/baseapp"
+	"github.com/cosmos/cosmos-sdk/runtime"
 	servertypes "github.com/cosmos/cosmos-sdk/server/types"
+	simtypes "github.com/cosmos/cosmos-sdk/types/simulation"
 	"github.com/zeta-chain/ethermint/app"
 	evmante "github.com/zeta-chain/ethermint/app/ante"
 
@@ -66,3 +70,30 @@ func PrintStats(db dbm.DB) {
 	fmt.Println(db.Stats()["leveldb.stats"])
 	fmt.Println("GoLevelDB cached block size", db.Stats()["leveldb.cachedblock"])
 }
+
+// CheckExportSimulation exports the app state and simulation parameters to JSON
+// if the export paths are defined.
+func CheckExportSimulation(app runtime.AppI, config simtypes.Config, params simtypes.Params) error {
+	if config.ExportStatePath != "" {
+		exported, err := app.ExportAppStateAndValidators(false, nil, nil)
+		if err != nil {
+			return err
+		}
+
+		if err := os.WriteFile(config.ExportStatePath, []byte(exported.AppState), 0o600); err != nil {
+			return err
+		}
+	}
+
+	if config.ExportParamsPath != "" {
+		paramsBz, err := json.MarshalIndent(params, "", " ")
+		if err != nil {
+			return err
+		}
+
+		if err := os.WriteFile(config.ExportParamsPath, paramsBz, 0o600); err != nil {
+			return err
+		}
+	}
+	return nil
+}