New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support `depositAndCall` and `withdrawAndCall` with empty message #3018

Merged

lumtis merged 20 commits into develop from feat/transferAndCall

Oct 22, 2024

Merged

fix: support `depositAndCall` and `withdrawAndCall` with empty message #3018

keepertest

Codecov / codecov/patch failed Oct 22, 2024 in 1s

7.53% of diff hit (target 64.91%)

View this Pull Request on Codecov

7.53% of diff hit (target 64.91%)

Annotations

Check warning on line 234 in pkg/contracts/testdappv2/TestDAppV2.go

codecov / codecov/patch

pkg/contracts/testdappv2/TestDAppV2.go#L228-L234

Added lines #L228 - L234 were not covered by tests

Check warning on line 238 in pkg/contracts/testdappv2/TestDAppV2.go

codecov / codecov/patch

pkg/contracts/testdappv2/TestDAppV2.go#L236-L238

Added lines #L236 - L238 were not covered by tests

Check warning on line 246 in pkg/contracts/testdappv2/TestDAppV2.go

codecov / codecov/patch

pkg/contracts/testdappv2/TestDAppV2.go#L245-L246

Added lines #L245 - L246 were not covered by tests

Check warning on line 253 in pkg/contracts/testdappv2/TestDAppV2.go

codecov / codecov/patch

pkg/contracts/testdappv2/TestDAppV2.go#L252-L253

Added lines #L252 - L253 were not covered by tests

Check warning on line 389 in pkg/contracts/testdappv2/TestDAppV2.go

codecov / codecov/patch

pkg/contracts/testdappv2/TestDAppV2.go#L383-L389

Added lines #L383 - L389 were not covered by tests

Check warning on line 393 in pkg/contracts/testdappv2/TestDAppV2.go

codecov / codecov/patch

pkg/contracts/testdappv2/TestDAppV2.go#L391-L393

Added lines #L391 - L393 were not covered by tests

Check warning on line 401 in pkg/contracts/testdappv2/TestDAppV2.go

codecov / codecov/patch

pkg/contracts/testdappv2/TestDAppV2.go#L400-L401

Added lines #L400 - L401 were not covered by tests

Check warning on line 408 in pkg/contracts/testdappv2/TestDAppV2.go

codecov / codecov/patch

pkg/contracts/testdappv2/TestDAppV2.go#L407-L408

Added lines #L407 - L408 were not covered by tests

Check warning on line 41 in x/crosschain/keeper/v2_zevm_inbound.go

codecov / codecov/patch

x/crosschain/keeper/v2_zevm_inbound.go#L40-L41

Added lines #L40 - L41 were not covered by tests

Check warning on line 49 in x/crosschain/keeper/v2_zevm_inbound.go

codecov / codecov/patch

x/crosschain/keeper/v2_zevm_inbound.go#L43-L49

Added lines #L43 - L49 were not covered by tests

Check warning on line 54 in x/crosschain/keeper/v2_zevm_inbound.go

codecov / codecov/patch

x/crosschain/keeper/v2_zevm_inbound.go#L54

Added line #L54 was not covered by tests

Check warning on line 75 in x/crosschain/keeper/v2_zevm_inbound.go

codecov / codecov/patch

x/crosschain/keeper/v2_zevm_inbound.go#L61-L75

Added lines #L61 - L75 were not covered by tests

Check warning on line 103 in x/crosschain/keeper/v2_zevm_inbound.go

codecov / codecov/patch

x/crosschain/keeper/v2_zevm_inbound.go#L84-L103

Added lines #L84 - L103 were not covered by tests

Check warning on line 116 in x/crosschain/keeper/v2_zevm_inbound.go

codecov / codecov/patch

x/crosschain/keeper/v2_zevm_inbound.go#L108-L116

Added lines #L108 - L116 were not covered by tests

Check warning on line 240 in x/crosschain/types/cctx.go

codecov / codecov/patch

x/crosschain/types/cctx.go#L240

Added line #L240 was not covered by tests

Check warning on line 43 in x/crosschain/types/inbound_parsing.go

codecov / codecov/patch

x/crosschain/types/inbound_parsing.go#L23-L43

Added lines #L23 - L43 were not covered by tests

Check warning on line 58 in x/crosschain/types/inbound_parsing.go

codecov / codecov/patch

x/crosschain/types/inbound_parsing.go#L51-L58

Added lines #L51 - L58 were not covered by tests

Check warning on line 60 in x/crosschain/types/inbound_parsing.go

codecov / codecov/patch

x/crosschain/types/inbound_parsing.go#L60

Added line #L60 was not covered by tests

Check warning on line 76 in x/crosschain/types/inbound_parsing.go

codecov / codecov/patch

x/crosschain/types/inbound_parsing.go#L68-L76

Added lines #L68 - L76 were not covered by tests

Check warning on line 92 in x/crosschain/types/inbound_parsing.go

codecov / codecov/patch

x/crosschain/types/inbound_parsing.go#L84-L92

Added lines #L84 - L92 were not covered by tests

Check warning on line 111 in x/crosschain/types/inbound_parsing.go

codecov / codecov/patch

x/crosschain/types/inbound_parsing.go#L107-L111

Added lines #L107 - L111 were not covered by tests

Check warning on line 116 in x/crosschain/types/inbound_parsing.go

codecov / codecov/patch

x/crosschain/types/inbound_parsing.go#L113-L116

Added lines #L113 - L116 were not covered by tests

Check warning on line 121 in x/crosschain/types/inbound_parsing.go

codecov / codecov/patch

x/crosschain/types/inbound_parsing.go#L118-L121

Added lines #L118 - L121 were not covered by tests

Check warning on line 127 in x/crosschain/types/inbound_parsing.go

codecov / codecov/patch

x/crosschain/types/inbound_parsing.go#L124-L127

Added lines #L124 - L127 were not covered by tests

Check warning on line 148 in x/crosschain/types/inbound_parsing.go

codecov / codecov/patch

x/crosschain/types/inbound_parsing.go#L129-L148

Added lines #L129 - L148 were not covered by tests

View more details on Codecov