Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove btc deposit fee v1 and improve unit tests #2899

Merged
merged 11 commits into from
Sep 23, 2024

Merge branch 'develop' of https://github.com/zeta-chain/node into rem…

e38ca8e
Select commit
Loading
Failed to load commit list.
Merged

refactor: remove btc deposit fee v1 and improve unit tests #2899

Merge branch 'develop' of https://github.com/zeta-chain/node into rem…
e38ca8e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 19, 2024 in 0s

67.16% (+0.03%) compared to 9b704a5

View this Pull Request on Codecov

67.16% (+0.03%) compared to 9b704a5

Details

Codecov Report

Attention: Patch coverage is 59.01639% with 25 lines in your changes missing coverage. Please review.

Project coverage is 67.16%. Comparing base (9b704a5) to head (e38ca8e).

Files with missing lines Patch % Lines
zetaclient/chains/bitcoin/observer/inbound.go 58.00% 21 Missing ⚠️
zetaclient/chains/base/observer.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2899      +/-   ##
===========================================
+ Coverage    67.12%   67.16%   +0.03%     
===========================================
  Files          378      378              
  Lines        21121    21111      -10     
===========================================
+ Hits         14178    14179       +1     
+ Misses        6276     6266      -10     
+ Partials       667      666       -1     
Files with missing lines Coverage Δ
zetaclient/chains/bitcoin/fee.go 41.52% <ø> (+3.54%) ⬆️
zetaclient/chains/bitcoin/observer/observer.go 32.63% <ø> (-5.68%) ⬇️
zetaclient/chains/bitcoin/observer/witness.go 71.11% <100.00%> (+0.32%) ⬆️
zetaclient/chains/base/observer.go 85.22% <0.00%> (-1.72%) ⬇️
zetaclient/chains/bitcoin/observer/inbound.go 20.74% <58.00%> (+6.61%) ⬆️