test: initialize liquidity cap for newly deployed erc20 in WhiteListERC20 e2e test

[kingpinXD]

Description

Closes : #2888

How Has This Been Tested?

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

Summary by CodeRabbit

• New Features

  • Enhanced test functionality by ensuring proper initialization of the liquidity cap for ERC20 tokens.

• Refactor

  • Renamed method for initializing liquidity cap to improve readability and maintainability.

[coderabbitai]

Walkthrough

Walkthrough

The pull request introduces modifications to the TestWhitelistERC20 function in the e2e/e2etests/test_whitelist_erc20.go file, adding a call to initialize the liquidity cap for an ERC20 token. Additionally, it renames a method in the ZetaTxServer struct from initializeLiquidityCap to InitializeLiquidityCap, ensuring consistency with Go's naming conventions. These changes enhance the functionality and readability of the code related to liquidity cap initialization.

Changes

File	Change Summary
e2e/e2etests/test_whitelist_erc20.go	Added a call to r.ZetaTxServer.InitializeLiquidityCap(erc20zrc20Addr) in TestWhitelistERC20.
e2e/txserver/zeta_tx_server.go	Renamed method initializeLiquidityCap to InitializeLiquidityCap in ZetaTxServer struct. Updated comments accordingly.

Possibly related PRs

• refactor(fungible): set default liquidity cap for new ZRC20s #2802: This PR involves changes to the ZetaTxServer class, specifically in the DeployZRC20s function, where the initialization of the liquidity cap is modularized, which is directly related to the changes made in the main PR regarding the initialization of liquidity caps for ERC20 tokens.

Suggested labels

no-changelog, V2_MIGRATION_TESTS

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 77cf636 and 8283ede.

Files selected for processing (2)

• e2e/e2etests/test_whitelist_erc20.go (1 hunks)
• e2e/txserver/zeta_tx_server.go (5 hunks)

Files skipped from review due to trivial changes (1)

• e2e/txserver/zeta_tx_server.go

Additional context used

Path-based instructions (1)

e2e/e2etests/test_whitelist_erc20.go (1)

Pattern **/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.

Additional comments not posted (1)

e2e/e2etests/test_whitelist_erc20.go (1)

53-54: LGTM!

The liquidity cap initialization is a critical step in the test, and the code segment handles it elegantly. The error handling ensures that the test fails if the initialization fails, preventing false positives.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.