-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: emit events from staking precompile #2861
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughWalkthroughThe pull request introduces significant modifications across various files, primarily focusing on enhancing staking functionalities within the blockchain context. Key changes include the removal of the Changes
Assessment against linked issues
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2861 +/- ##
===========================================
- Coverage 66.81% 66.80% -0.02%
===========================================
Files 371 373 +2
Lines 20910 20993 +83
===========================================
+ Hits 13972 14025 +53
- Misses 6300 6315 +15
- Partials 638 653 +15
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a quick look , maybe my understanding is wrong , so wanted to clarify before adding more comments.
Should the staking precompiles functionality follow the naming / terminology of regular staking as much as possible , or is there a reason behind using different terms , because I see all three functions implemented have different names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I really like the shape this is taking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification ,regarding the naming ,
I see the logs are added to the state DB. Would you be able to confirm what is the underlying database file which this gets added into ? application.db
or tx_index.db
Cosmos logs are stored as part of block result so they end up in tx_index.db which is fine because we can define the config for tx_index.db separately .
However if these logs end up in application.db , we should consider the implications on the state growth .
Actually it seems to be fine , the logs go the transient store , which is discarded , would be great if you could double check as well |
yes should be ok i think |
Description
Emit events in stake, unstake and moveStake functions of staking precompile contract. Extend e2e tests to check if events are emitted.
closes: #2811
How Has This Been Tested?
Summary by CodeRabbit
New Features
MoveStake
,Stake
, andUnstake
to enhance tracking and transparency.Bug Fixes
Documentation