test(e2e): backport protocol contract v2 migration test

[lumtis]

Description

Part of #2779

Backport #2763 to v20

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (1)

• develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[skosito]

it seems that cmd/zetae2e/local/migration.go was removed in original PR but not here, and some not related changes in zetaclient/chains/bitcoin/observer/observer.go in original PR

[lumtis]

it seems that cmd/zetae2e/local/migration.go was removed in original PR but not here

This was a refactoring for code quality migration -> tss migration, not necessary here

and some not related changes in zetaclient/chains/bitcoin/observer/observer.go in original PR

refactoring to improve logs emitted in localnet, I deemed not crucial for the backport

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 66.72%. Comparing base (293f194) to head (4e2c035).
Report is 1 commits behind head on release/v20.

Files with missing lines	Patch %	Lines
zetaclient/orchestrator/orchestrator.go	8.33%	10 Missing and 1 partial ⚠️
...gible/keeper/msg_server_update_gateway_contract.go	55.00%	7 Missing and 2 partials ⚠️
zetaclient/chains/evm/signer/signer.go	0.00%	4 Missing ⚠️
x/fungible/keeper/v2_evm.go	87.50%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           release/v20    #2821      +/-   ##
===============================================
- Coverage        66.73%   66.72%   -0.02%     
===============================================
  Files              364      364              
  Lines            20510    20554      +44     
===============================================
+ Hits             13687    13714      +27     
- Misses            6195     6209      +14     
- Partials           628      631       +3     

Files with missing lines	Coverage Δ
x/fungible/keeper/v2_evm.go	27.41% <87.50%> (+8.90%)	⬆️
zetaclient/chains/evm/signer/signer.go	47.15% <0.00%> (-0.46%)	⬇️
...gible/keeper/msg_server_update_gateway_contract.go	72.72% <55.00%> (-6.44%)	⬇️
zetaclient/orchestrator/orchestrator.go	22.04% <8.33%> (-0.30%)	⬇️

[julianrubino]

lgtm