-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use single input for e2e workflow_dispatch #2777
Conversation
WalkthroughWalkthroughThe changes involve the restructuring of the input parameters in the GitHub Actions workflow configuration file Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub Actions
participant Workflow
User->>GitHub Actions: Trigger Workflow with `make-targets`
GitHub Actions->>Workflow: Receive `make-targets` input
Workflow->>Workflow: Parse `make-targets`
alt Test Included
Workflow->>Workflow: Execute corresponding test
else No Test Included
Workflow->>Workflow: Skip execution
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
f83102e
to
fe67233
Compare
fe67233
to
828b4be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/e2e.yml (2 hunks)
Additional comments not posted (2)
.github/workflows/e2e.yml (2)
16-19
: LGTM!The new input parameter
make-targets
is well-defined and addresses the limitation of having more than 10 inputs.The code changes are approved.
91-101
: LGTM!The logic for parsing the
make-targets
input and setting the outputs is correctly implemented.The code changes are approved.
With #2763 we now have 11 e2e test targets. This is greater than the maximum number of inputs (10). Reference
Move to a single comma separated input.
Example run: https://github.com/zeta-chain/node/actions/runs/10583082282
Summary by CodeRabbit
make-targets
, allowing users to specify multiple tests in a comma-separated format.