-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: upgrade go-tss to tss-lib v2 #2767
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## upgrade-btc-deps #2767 +/- ##
====================================================
- Coverage 66.90% 66.89% -0.02%
====================================================
Files 364 364
Lines 20471 20461 -10
====================================================
- Hits 13697 13687 -10
Misses 6146 6146
Partials 628 628
|
Changes LGTM. |
The plan now is to use the threshold-network fork rather than the bnb-chain version: zeta-chain/go-tss#28 |
Upgrade tss-lib to v2 to resolve security issues.
The pre-params need to be upgraded for the new
PaillierSK.{P,Q}
parameters. The pre-params can be upgraded without impacting ongoing keysigns as they are only used for keygen (keysign uses the local state store for its parameters).TODO: