Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: upgrade go-tss to tss-lib v2 #2767

Closed
wants to merge 1 commit into from
Closed

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Aug 23, 2024

Upgrade tss-lib to v2 to resolve security issues.

The pre-params need to be upgraded for the new PaillierSK.{P,Q} parameters. The pre-params can be upgraded without impacting ongoing keysigns as they are only used for keygen (keysign uses the local state store for its parameters).

TODO:

@gartnera gartnera added UPGRADE_TESTS Run make start-upgrade-tests TSS_MIGRATION_TESTS Run TSS migration tests PERFORMANCE_TESTS Run make start-e2e-performance-test labels Aug 23, 2024
Copy link
Contributor

coderabbitai bot commented Aug 23, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (1)
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gartnera gartnera mentioned this pull request Aug 26, 2024
2 tasks
@gartnera gartnera changed the title chore: upgrade go-tss to tss-lib v2 chore!: upgrade go-tss to tss-lib v2 Aug 26, 2024
@gartnera gartnera removed the TSS_MIGRATION_TESTS Run TSS migration tests label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.89%. Comparing base (a36fc6d) to head (8d7b6d6).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           upgrade-btc-deps    #2767      +/-   ##
====================================================
- Coverage             66.90%   66.89%   -0.02%     
====================================================
  Files                   364      364              
  Lines                 20471    20461      -10     
====================================================
- Hits                  13697    13687      -10     
  Misses                 6146     6146              
  Partials                628      628              
Files with missing lines Coverage Δ
zetaclient/tss/tss_signer.go 9.56% <ø> (ø)

... and 1 file with indirect coverage changes

@fbac
Copy link
Contributor

fbac commented Sep 2, 2024

Changes LGTM.
Regarding the TODO list, I'm assuming that's the order you'll be merging all those PR's?

@gartnera
Copy link
Member Author

The plan now is to use the threshold-network fork rather than the bnb-chain version: zeta-chain/go-tss#28

@gartnera gartnera closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:cli PERFORMANCE_TESTS Run make start-e2e-performance-test UPGRADE_TESTS Run make start-upgrade-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants