-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use large runner for release build #2733
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughWalkthroughThe recent changes to the GitHub Actions workflow enhance the configurability and control of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/publish-release.yml (2 hunks)
Additional comments not posted (2)
.github/workflows/publish-release.yml (2)
127-128
: Dependency addition forpublish-release
approved.Including
check-goreleaser
as a dependency for thepublish-release
job ensures that the release process only continues if the necessary checks are successful, enhancing the reliability of the release workflow.
35-36
: Conditional execution and dynamic runner configuration approved.The introduction of conditional execution for the
check-goreleaser
job and the use of a dynamic runner environment via${{ vars.RELEASE_RUNNER }}
enhance the workflow's flexibility and configurability. Ensure that theRELEASE_RUNNER
variable is correctly defined and accessible in the workflow context.
The release build has been randomly failing because it runs out of disk space:
Use a configurable runner in the release workflow to allow running on larger runners if needed without having to update the workflow. It currently is configured to run on large github actions runners. You can check what runner built on via the build logs. The release attestation will indicate if the binaries were built on a github managed runner.
Also always run the release dry run before the release to ensure we can acutally build the release before cutting the tag. This should reduce the amount of pointless retagging we have to do.
Actions release check run: https://github.com/zeta-chain/node/actions/runs/10425868668/job/28877657855
Summary by CodeRabbit
New Features
Bug Fixes