Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use large runner for release build #2733

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Aug 16, 2024

The release build has been randomly failing because it runs out of disk space:

/usr/local/go/pkg/tool/linux_amd64/link: /usr/local/go/pkg/tool/linux_amd64/link: combining dwarf failed: write $WORK/b001/exe/a.out~: no space left on device

Use a configurable runner in the release workflow to allow running on larger runners if needed without having to update the workflow. It currently is configured to run on large github actions runners. You can check what runner built on via the build logs. The release attestation will indicate if the binaries were built on a github managed runner.

Also always run the release dry run before the release to ensure we can acutally build the release before cutting the tag. This should reduce the amount of pointless retagging we have to do.

Actions release check run: https://github.com/zeta-chain/node/actions/runs/10425868668/job/28877657855

Summary by CodeRabbit

  • New Features

    • Enhanced configurability of the release workflow, allowing users to skip checks based on their input.
    • Improved flexibility of the runner environment used for executing jobs.
  • Bug Fixes

    • Adjusted job dependencies to ensure proper execution order, prioritizing essential checks.

@gartnera gartnera added the no-changelog Skip changelog CI check label Aug 16, 2024
@gartnera gartnera requested a review from a team as a code owner August 16, 2024 20:36
Copy link
Contributor

coderabbitai bot commented Aug 16, 2024

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Walkthrough

The recent changes to the GitHub Actions workflow enhance the configurability and control of the check-goreleaser job in the .github/workflows/publish-release.yml file. A conditional execution based on user input has been introduced, allowing the job to run selectively. Additionally, the runner environment has been made dynamic by referencing a variable instead of a static value, improving adaptability for different release scenarios.

Changes

File Change Summary
.github/workflows/publish-release.yml Updated check-goreleaser job to include conditional execution based on skip_checks input. Changed runs-on from a static value to a dynamic variable reference for enhanced flexibility. Adjusted job dependencies for improved execution flow.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Aug 16, 2024
@gartnera gartnera enabled auto-merge August 16, 2024 20:36
Copy link
Contributor

@morde08 morde08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2f7cf0a and 274b6a3.

Files selected for processing (1)
  • .github/workflows/publish-release.yml (2 hunks)
Additional comments not posted (2)
.github/workflows/publish-release.yml (2)

127-128: Dependency addition for publish-release approved.

Including check-goreleaser as a dependency for the publish-release job ensures that the release process only continues if the necessary checks are successful, enhancing the reliability of the release workflow.


35-36: Conditional execution and dynamic runner configuration approved.

The introduction of conditional execution for the check-goreleaser job and the use of a dynamic runner environment via ${{ vars.RELEASE_RUNNER }} enhance the workflow's flexibility and configurability. Ensure that the RELEASE_RUNNER variable is correctly defined and accessible in the workflow context.

@gartnera gartnera changed the title ci: use large runner for release ci: use large runner for release build Aug 16, 2024
@gartnera gartnera added this pull request to the merge queue Aug 16, 2024
Merged via the queue into develop with commit 01ec55e Aug 16, 2024
40 checks passed
@gartnera gartnera deleted the use-large-runner-for-release branch August 16, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants