-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use ghcr docker images to avoid rate limiting #2600
Conversation
WalkthroughWalkthroughThe recent updates involve a transition from Docker Hub to GitHub Container Registry (ghcr.io) for several Docker images across multiple components, including the Dockerfile for localnet and the orchestrator. This shift aims to leverage potentially optimized images hosted in the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CI/CD
participant ghcr.io
participant Docker
participant Application
Developer->>CI/CD: Push changes
CI/CD->>ghcr.io: Pull updated images
ghcr.io-->>CI/CD: Provide images
CI/CD->>Docker: Build application
Docker-->>Application: Deploy updated application
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
7daa83b
to
6e14a23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- Dockerfile-localnet (2 hunks)
- contrib/localnet/docker-compose.yml (3 hunks)
- contrib/localnet/orchestrator/Dockerfile.fastbuild (1 hunks)
Additional comments not posted (8)
contrib/localnet/orchestrator/Dockerfile.fastbuild (2)
2-2
: Approved: Update base image to GitHub Container Registry.The base image for the Ethereum client has been updated to
ghcr.io/zeta-chain/ethereum-client-go:v1.10.26
. Ensure that the new image is available and correctly referenced.
3-3
: Approved: Update base image to GitHub Container Registry.The base image for the Go language has been updated to
ghcr.io/zeta-chain/golang:1.22.5-bookworm
. Ensure that the new image is available and correctly referenced.Dockerfile-localnet (3)
2-2
: Approved: Update base image to GitHub Container Registry.The base image for the
base-build
stage has been updated toghcr.io/zeta-chain/golang:1.22.5-bookworm
. Ensure that the new image is available and correctly referenced.
25-25
: Approved: Update base image to GitHub Container Registry.The base image for the
cosmovisor-build
stage has been updated toghcr.io/zeta-chain/golang:1.22.5-bookworm
. Ensure that the new image is available and correctly referenced.
28-28
: Approved: Update base image to GitHub Container Registry.The base image for the
base-runtime
stage has been updated toghcr.io/zeta-chain/golang:1.22.5-bookworm
. Ensure that the new image is available and correctly referenced.contrib/localnet/docker-compose.yml (3)
13-13
: Approved: Add guidance comment for third-party images in CI.The comment provides valuable guidance on using third-party images in CI and suggests copying them into GitHub Container Registry.
186-186
: Approved: Update image reference to GitHub Container Registry.The image reference for the
eth
service has been updated toghcr.io/zeta-chain/ethereum-client-go:v1.10.26
. Ensure that the new image is available and correctly referenced.
212-212
: Approved: Update image reference to GitHub Container Registry.The image reference for the
bitcoin
service has been updated toghcr.io/zeta-chain/ruimarinho-bitcoin-core:22
. Ensure that the new image is available and correctly referenced.
Occasionally CI will fail to pull an image because of docker hub rate limiting (we get 200 pulls per 6 hours).
https://github.com/zeta-chain/copy-docker-images copies relevant images into ghcr.io. Use those images in our CI Dockerfile and docker-compose files.
This must be done on github actions as only the CI token may push to ghcr.io
Summary by CodeRabbit
New Features
docker-compose.yml
with new image references for Ethereum and Bitcoin services.Documentation
docker-compose.yml
for using third-party images in CI.These changes improve the reliability and infrastructure of the application.