-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(codecov.yml
): fix config file
#2575
Conversation
WalkthroughWalkthroughThe recent modifications to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2575 +/- ##
============================================
+ Coverage 46.80% 71.57% +24.77%
============================================
Files 465 327 -138
Lines 30820 17798 -13022
============================================
- Hits 14425 12739 -1686
+ Misses 15539 4490 -11049
+ Partials 856 569 -287 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- codecov.yml (4 hunks)
Additional comments not posted (3)
codecov.yml (3)
18-22
: Ensure consistency in coverage targets and flags.The addition of the
pkg
entry aligns with the existing structure forzetacore
andzetaclient
. Ensure that the target coverage and flags are correctly set for thepkg
section.
36-38
: Verify the path for thepkg
flag.The addition of the
pkg
flag with the path "pkg/" is consistent with the naming convention changes. Ensure that the path correctly corresponds to the intended directory.
64-65
: Ensure the necessity of new ignore patterns.The addition of ignore patterns for
zetaclient/testdata/**/*
andzetaclient/testutils/**/*
helps in maintaining clarity. Ensure these directories contain files that should be excluded from coverage.
Description
Tentative to fix coverage number
Summary by CodeRabbit