fix(e2e): update performance test parameters and bump go-tss #2563
Conversation
WalkthroughWalkthroughThe recent changes enhance the performance testing framework by implementing default timeout values for Ethereum withdrawal operations, updating dependency versions for stability, and refining timeout management in the test runner. These modifications aim to address persistent performance test failures and improve overall robustness and reliability in transaction handling. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2563 +/- ##
========================================
Coverage 71.57% 71.57%
========================================
Files 327 327
Lines 17798 17798
========================================
Hits 12739 12739
Misses 4490 4490
Partials 569 569 |
gartnera
changed the title
gartnera
force-pushed
the
fix-performance-tests
branch
from
06b5b04 to
9080b61
Compare
gartnera
changed the title
gartnera
requested review from
brewmaster012,
kingpinXD,
lumtis,
ws4charlie,
skosito,
swift1337 and
fbac
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
go.mod (1)
364-364: Issue Found: Dependency Replacement Not AppliedThe replacement of
github.com/libp2p/go-libp2pwithgithub.com/zeta-chain/go-libp2phas not been applied correctly. The original dependency is still present in the following files:
zetaclient/tss/tss_signer.gocmd/zetaclientd/p2p_diagnostics.goPlease ensure that all instances of
github.com/libp2p/go-libp2pare replaced withgithub.com/zeta-chain/go-libp2pto align with the intended changes.Analysis chain
LGTM! Verify the impact of the
go-libp2preplacement.The replacement of
github.com/libp2p/go-libp2pwithgithub.com/zeta-chain/go-libp2pis approved.However, ensure that the new dependency does not introduce any breaking changes or regressions in the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of the `go-libp2p` replacement. # Test: Search for the usage of `go-libp2p` in the codebase. Expect: No breaking changes or regressions. rg --type go 'go-libp2p'Length of output: 753
Script:
#!/bin/bash # Description: Verify the replacement of `go-libp2p` with `zeta-chain/go-libp2p`. # Test: Search for the usage of `zeta-chain/go-libp2p` in the codebase to ensure proper replacement. rg --type go 'github.com/zeta-chain/go-libp2p'Length of output: 46
Script:
#!/bin/bash # Description: Verify if the original `go-libp2p` dependency is still present in the codebase. # Test: Search for the usage of `github.com/libp2p/go-libp2p` in the codebase to confirm its presence. rg --type go 'github.com/libp2p/go-libp2p'Length of output: 771
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (4)
- Makefile (1 hunks)
- cmd/zetae2e/local/performance.go (1 hunks)
- cmd/zetae2e/local/test_runner.go (1 hunks)
- go.mod (1 hunks)
Additional context used
Path-based instructions (2)
cmd/zetae2e/local/test_runner.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.cmd/zetae2e/local/performance.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
Additional comments not posted (4)
cmd/zetae2e/local/test_runner.go (1)
33-35: LGTM! Ensure consistent usage of timeout settings.The added lines to copy timeout values from the deployer runner improve consistency in timeout handling.
However, ensure that these timeout settings are correctly used across the codebase.
Verification successful
LGTM! Ensure consistent usage of timeout settings.
The added lines to copy timeout values from the deployer runner improve consistency in timeout handling.
Verified consistent usage of
CctxTimeoutandReceiptTimeoutacross the codebase.The timeout settings are correctly used in various files for context management and transaction receipt handling, which aligns with their intended purpose.
e2e/runner/setup_zeta.goe2e/runner/setup_evm.goe2e/runner/evm.goe2e/runner/zeta.goe2e/e2etests/test_message_passing_external_chains_revert_fail.goe2e/e2etests/test_bitcoin_withdraw_invalid_address.goe2e/e2etests/test_zeta_withdraw.goe2e/e2etests/test_zeta_deposit_new_address.goe2e/e2etests/test_update_bytecode_zrc20.goe2e/e2etests/test_pause_zrc20.goe2e/e2etests/test_stress_btc_withdraw.goe2e/e2etests/test_stress_btc_deposit.goe2e/e2etests/test_solana_deposit.goe2e/e2etests/test_rate_limiter.goe2e/e2etests/test_migrate_tss.goe2e/e2etests/test_message_passing_zevm_to_evm_revert_fail.goe2e/e2etests/test_message_passing_zevm_to_evm_revert.goe2e/e2etests/test_message_passing_zevm_to_evm.goe2e/e2etests/test_message_passing_external_chains.goe2e/e2etests/test_message_passing_evm_to_zevm.goe2e/e2etests/test_eth_withdraw_restricted_address.goe2e/e2etests/test_eth_withdraw.goe2e/e2etests/test_eth_deposit_refund.goe2e/e2etests/test_stress_eth_withdraw.goe2e/e2etests/test_eth_deposit_call.goe2e/e2etests/test_eth_deposit.goe2e/e2etests/test_erc20_withdraw.goe2e/e2etests/test_erc20_multiple_withdraws.goe2e/e2etests/test_update_bytecode_connector.goe2e/e2etests/test_eth_deposit_liquidity_cap.goe2e/e2etests/test_zrc20_swap.goe2e/e2etests/test_erc20_deposit_refund.goe2e/e2etests/test_deploy_contract.goe2e/e2etests/test_crosschain_swap.goe2e/e2etests/test_context_upgrade.goe2e/e2etests/test_bitcoin_deposit.goe2e/e2etests/helpers.goe2e/e2etests/test_message_passing_evm_to_zevm_revert_fail.goe2e/e2etests/test_message_passing_evm_to_zevm_revert.goe2e/e2etests/test_migrate_chain_support.goe2e/e2etests/test_erc20_multiple_deposits.goe2e/e2etests/test_erc20_deposit.goe2e/e2etests/test_stress_eth_deposit.goe2e/e2etests/test_donation.gocmd/zetae2e/stress.gocmd/zetae2e/run.gocmd/zetae2e/local/test_runner.gocmd/zetae2e/local/performance.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of CctxTimeout and ReceiptTimeout in the codebase. # Test: Search for the usage of timeout settings. Expect: Consistent usage of CctxTimeout and ReceiptTimeout. rg --type go -A 5 'CctxTimeout|ReceiptTimeout'Length of output: 76570
cmd/zetae2e/local/performance.go (1)
78-83: LGTM! Ensure default timeout values are appropriate.The added lines to set default timeout values improve the robustness of the function.
However, ensure that these default timeout values are appropriate for all scenarios.
Makefile (1)
252-252: LGTM! Ensure correct usage of--profile stressoption.The added line to include the
--profile stressoption enhances the testing approach.However, ensure that the
--profile stressoption is correctly used in the Docker Compose configuration.Verification successful
Verified: The
--profile stressoption is correctly used in the Docker Compose configuration.The
stressprofile is defined in thecontrib/localnet/docker-compose.ymlfile, confirming the correct usage of the--profile stressoption.
contrib/localnet/docker-compose.ymlScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `--profile stress` option in the Docker Compose configuration. # Test: Search for the usage of `--profile stress` option. Expect: Correct usage in the Docker Compose configuration. rg --type yaml -A 5 '--profile stress'Length of output: 459
Script:
#!/bin/bash # Description: Verify the usage of the `stress` profile in Docker Compose configuration files. # Test: Search for the `profiles` key in YAML files and check if `stress` is listed as a profile. rg 'profiles:' -A 5 --type yamlLength of output: 4393
go.mod (1)
367-367: LGTM! Verify the impact of thego-tssupdate.The update to
github.com/zeta-chain/go-tssfromv0.0.0-20240718213003-31767e0c90batov0.0.0-20240729195411-9f5ae8189449is approved.However, ensure that the new version does not introduce any breaking changes or regressions in the codebase.
Verification successful
The update to
go-tssdoes not introduce breaking changes or regressions.The changes between the specified versions are related to concurrency and scale testing, as well as CI linting improvements. These updates do not affect the core functionality of the
go-tsslibrary.
- Commit
9f5ae81: "Add concurrency and scale testing"- Commit
76ca65a: "ci: add linting"Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of the `go-tss` update. # Test: Search for the usage of `go-tss` in the codebase. Expect: No breaking changes or regressions. rg --type go 'go-tss'Length of output: 1146
Script:
#!/bin/bash # Description: Verify the impact of the `go-tss` update by inspecting the usage in the identified files. # List of files using `go-tss` files=( "zetaclient/zetacore/tx_test.go" "zetaclient/zetacore/client_vote.go" "zetaclient/tss/tss_signer.go" "zetaclient/tss/concurrent_keysigns_tracker.go" "zetaclient/testutils/mocks/zetacore_client.go" "x/observer/types/utils_test.go" "x/observer/types/utils.go" "zetaclient/chains/interfaces/interfaces.go" "x/observer/client/cli/tx_vote_blame.go" "cmd/zetaclientd/keygen_tss.go" ) # Inspect each file for usage of `go-tss` for file in "${files[@]}"; do echo "Inspecting $file" rg 'gitlab.com/thorchain/tss/go-tss' "$file" doneLength of output: 2980
Script:
#!/bin/bash # Description: Fetch the changelog or commit history of the `go-tss` library to identify any breaking changes or significant updates. # Fetch the commit history for the `go-tss` library from the old version to the new version. git log 31767e0c90ba..9f5ae8189449 --oneline --no-mergesLength of output: 265
Script:
#!/bin/bash # Description: Clone the `go-tss` repository and fetch the commit history between the specified versions. # Clone the `go-tss` repository git clone https://github.com/zeta-chain/go-tss.git # Navigate into the repository directory cd go-tss # Fetch the commit history between the specified versions git log 31767e0c90ba..9f5ae8189449 --oneline --no-mergesLength of output: 288
* fix(e2e): increase performance test timeouts * bump go-tss
* fix(ci): use static preparams for zetaclient by default (#2587) * refactor: move localnet monitoring to profile (#2574) Co-authored-by: Lucas Bertrand <[email protected]> * fix(e2e): update performance test parameters and bump go-tss (#2563) * fix(e2e): increase performance test timeouts * bump go-tss * fix(ci): remove job concurrency (#2595) * ci: run on PRs to all base branches --------- Co-authored-by: Lucas Bertrand <[email protected]>
Timeout increases are needed because some withdrawals are taking longer than the default 5 minute cctx timeout:
Closes #2562
Summary by CodeRabbit
New Features
Chores