-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add additional tags for identification on nightly performance test runs #2539
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughWalkthroughThe recent changes enhance the GitHub Actions workflow for performance testing by introducing new metadata tags in the configuration file and adding a dynamic environment variable to capture the action's name. These updates improve the traceability and context of performance test executions without altering existing logic, thereby enriching the overall functionality of the testing process. Changes
Sequence Diagram(s)sequenceDiagram
participant A as GitHub Action
participant B as ci-nightly-performance-testing.yaml
participant C as art.yaml
A->>B: Start performance testing
B->>B: Set GITHUB_ACTION = current action name
B->>C: Replace placeholder with GITHUB_ACTION value
C->>C: Update configuration with new metadata
B->>A: Complete testing with updated config
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- .github/actions/performance-tests/art.yaml (1 hunks)
- .github/workflows/ci-nightly-performance-testing.yaml (1 hunks)
Additional comments not posted (3)
.github/workflows/ci-nightly-performance-testing.yaml (2)
41-41
: Addition ofGITHUB_ACTION
environment variable approved.The inclusion of the
GITHUB_ACTION
environment variable enhances the dynamic configuration of the performance testing by allowing the action name to be included in the generated YAML file. This can be useful for logging or debugging purposes.
47-48
: Use ofGITHUB_ACTION
insed
command approved.The
sed
command correctly replaces the-=GITHUB_ACTION=-
placeholder in theart.yaml
file with the value of theGITHUB_ACTION
environment variable..github/actions/performance-tests/art.yaml (1)
22-23
: Addition oftestId
andjobName
tags approved.The inclusion of the
testId:-=GITHUB_ACTION=-
andjobName:evm-performance-test
tags enhances the configuration by providing additional metadata for the performance tests, facilitating better categorization and identification of specific test executions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Description
add additional tags
jobName
andtestId
for identification on nightly performance test runs for when reports are uploaded to Pushgateway/Grafana.How Has This Been Tested?
Summary by CodeRabbit
These improvements aim to enhance the organization and traceability of performance testing within the workflow.