ci: set fail-fast on job #2530
ci: set fail-fast on job #2530
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughWalkthroughThe recent modification to the GitHub Actions workflow introduces a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CI/CD Pipeline
participant Job A
participant Job B
participant Job C
User->>CI/CD Pipeline: Start Workflow
CI/CD Pipeline->>Job A: Execute Job A
alt Job A Fails
Job A-->>CI/CD Pipeline: Fail
else Job A Succeeds
Job A-->>CI/CD Pipeline: Success
end
CI/CD Pipeline->>Job B: Execute Job B
CI/CD Pipeline->>Job C: Execute Job C
This diagram illustrates the interaction flow in the CI/CD process before and after introducing the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
gartnera
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/reusable-e2e.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/reusable-e2e.yml (1)
28-29: Correctly Implementedfail-fastStrategy at Job LevelThe addition of the
strategykey withfail-fastset tofalseensures that the workflow continues executing other jobs even if one fails. This aligns with the objective of providing more comprehensive testing and feedback.
gartnera
force-pushed
the
fix-nightly-cancel
branch
3 times, most recently
from
77e9eb9 to
524a968
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2530 +/- ##
===========================================
+ Coverage 46.50% 46.90% +0.40%
===========================================
Files 456 460 +4
Lines 30282 31261 +979
===========================================
+ Hits 14083 14664 +581
- Misses 15372 15743 +371
- Partials 827 854 +27 |
Description
Setting
fail-faston the matrix is not working, let's try setting it on the job too. Correct behavior is that matrix jobs are not cancelled if one fails. For the nightly runs, we want to see exactly what failed.https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
Summary by CodeRabbit