Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zetaclient): increase gas limit inbound and outbound vote message to 500k #2481

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Jul 15, 2024

Description

Increase the gas limit to 500_000 for vote inbound message to prevent out of gas issue that occurred with voting processing

Closes: #2468

How Has This Been Tested?

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Summary by CodeRabbit

  • New Features
    • Increased gas limit for inbound and outbound vote messages to 500k, providing enhanced transaction capacity and reliability.

Copy link
Contributor

coderabbitai bot commented Jul 15, 2024

Walkthrough

The recent update to the zeta-chain/node repository, version 2481, increases the gas limit for inbound and outbound vote messages to 500,000. This change ensures that the EVM observer client can handle larger and more complex vote actions efficiently.

Changes

Files/Paths Change Summary
changelog.md Documented the increase of gas limits for vote messages.
zetaclient/zetacore/constant.go Increased PostVoteInboundGasLimit and PostVoteOutboundGasLimit from 400,000 to 500,000.

Sequence Diagram(s)

The changes are straightforward and consist solely of updating constants; thus, no sequence diagram is necessary.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Increase gas limit to 500_000 (#2468)

Poem

In the land where code does play,
Gas limits rise, clearing the way,
For votes inbound, outbound too,
500k is now the new.
Efficiency thrives, tasks now fleet,
In Zeta's world, a coding feat! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.21%. Comparing base (a076710) to head (5f41969).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2481      +/-   ##
===========================================
+ Coverage    47.16%   47.21%   +0.05%     
===========================================
  Files          444      444              
  Lines        29346    29358      +12     
===========================================
+ Hits         13840    13861      +21     
+ Misses       14696    14691       -5     
+ Partials       810      806       -4     

see 11 files with indirect coverage changes

@lumtis lumtis marked this pull request as ready for review July 15, 2024 12:47
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0d79cfb and 5f41969.

Files selected for processing (2)
  • changelog.md (1 hunks)
  • zetaclient/zetacore/constant.go (2 hunks)
Files skipped from review due to trivial changes (1)
  • zetaclient/zetacore/constant.go
Additional comments not posted (1)
changelog.md (1)

96-96: Ensure the changelog entry is accurate and complete.

The entry for increasing the gas limit for vote messages to 500,000 is correctly placed under the "Fixes" section. Ensure it accurately reflects the changes made in the codebase.

@fbac
Copy link
Contributor

fbac commented Jul 15, 2024

Description

Increase the gas limit to 500_000 for vote inbound message to prevent out of gas issue that occurred with voting processing

Closes: #2468

How Has This Been Tested?

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Summary by CodeRabbit

  • New Features

    • Increased gas limit for inbound and outbound vote messages to 500k, providing enhanced transaction capacity and reliability.

nit: for my own education, how has this 500k gas limit been chosen?

@fbac fbac added this pull request to the merge queue Jul 15, 2024
Merged via the queue into develop with commit 7823f24 Jul 15, 2024
29 checks passed
@fbac fbac deleted the refactor/increase-gas-limit-vote branch July 15, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase vote actions gas limit to 500_000
3 participants