-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(zetaclient
): increase gas limit inbound and outbound vote message to 500k
#2481
Conversation
WalkthroughThe recent update to the Changes
Sequence Diagram(s)The changes are straightforward and consist solely of updating constants; thus, no sequence diagram is necessary. Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2481 +/- ##
===========================================
+ Coverage 47.16% 47.21% +0.05%
===========================================
Files 444 444
Lines 29346 29358 +12
===========================================
+ Hits 13840 13861 +21
+ Misses 14696 14691 -5
+ Partials 810 806 -4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- changelog.md (1 hunks)
- zetaclient/zetacore/constant.go (2 hunks)
Files skipped from review due to trivial changes (1)
- zetaclient/zetacore/constant.go
Additional comments not posted (1)
changelog.md (1)
96-96
: Ensure the changelog entry is accurate and complete.The entry for increasing the gas limit for vote messages to 500,000 is correctly placed under the "Fixes" section. Ensure it accurately reflects the changes made in the codebase.
nit: for my own education, how has this 500k gas limit been chosen? |
Description
Increase the gas limit to 500_000 for vote inbound message to prevent out of gas issue that occurred with voting processing
Closes: #2468
How Has This Been Tested?
Summary by CodeRabbit