-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ci): finish matrix migration and update release workflow #2475
Conversation
WalkthroughRecent updates across several GitHub workflow files enhance the automation and testing processes. Changes include adding specific branches for triggering workflows, introducing new test types and conditional logic, removing redundant checks, and updating dependencies. These adjustments aim to streamline workflows, improve flexibility, and ensure comprehensive testing coverage. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2475 +/- ##
===========================================
+ Coverage 47.16% 47.21% +0.05%
===========================================
Files 444 444
Lines 29346 29358 +12
===========================================
+ Hits 13840 13861 +21
+ Misses 14696 14691 -5
+ Partials 810 806 -4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (6)
- .github/workflows/build.yml (2 hunks)
- .github/workflows/e2e.yml (4 hunks)
- .github/workflows/publish-release.yml (3 hunks)
- .github/workflows/reusable-e2e.yml (1 hunks)
- .github/workflows/sast-linters.yml (1 hunks)
- readme.md (1 hunks)
Files skipped from review due to trivial changes (3)
- .github/workflows/build.yml
- .github/workflows/sast-linters.yml
- readme.md
Additional comments not posted (8)
.github/workflows/reusable-e2e.yml (1)
104-104
: Ensure Slack notifications on failure for all event types.The change ensures that Slack notifications are triggered on failure for any event type, which is a good practice to keep track of failures.
.github/workflows/publish-release.yml (1)
14-14
: Clarify the description for skipping checks.The updated description clarifies which checks are skipped, improving the readability and understanding of the workflow.
.github/workflows/e2e.yml (6)
7-7
: Trigger the workflow on push to release branches.The workflow is now triggered by push events to the
release/*
branch, which ensures that the end-to-end tests are run for release branches as well.
16-45
: Addworkflow_dispatch
inputs for various test types.The addition of
workflow_dispatch
inputs allows for more granular control over which tests to run when manually triggering the workflow. This enhances the flexibility of the testing process.
60-63
: Update outputs inmatrix-conditionals
step.The updated outputs in the
matrix-conditionals
step ensure that the correct test flags are set based on the event type, improving the accuracy of the test execution conditions.
65-114
: Transition from CLI to GitHub API for context access and revise conditional logic.The transition from CLI to GitHub API for context access helps avoid race conditions and provides more reliable data. The revised conditional logic for setting test flags based on event types ensures that the correct tests are run under different conditions.
131-142
: Add new test job executions and adjust job conditions based on test flags.The addition of new test job executions and the adjustment of job conditions based on test flags enhance the coverage and flexibility of the end-to-end testing process.
153-155
: Updatee2e-ok
job dependencies.The updated dependencies for the
e2e-ok
job ensure that it runs after thematrix-conditionals
ande2e
jobs, maintaining the correct workflow sequence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some comments
Description
workflow_dispatch
actually workSummary by CodeRabbit