Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit events on revert #2466

Merged
merged 9 commits into from
Jul 16, 2024

fix new cctx status checking bug

cb06367
Select commit
Loading
Failed to load commit list.
Merged

fix: emit events on revert #2466

fix new cctx status checking bug
cb06367
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 16, 2024 in 1s

47.19% (-21.86%) compared to d0db41c

View this Pull Request on Codecov

47.19% (-21.86%) compared to d0db41c

Details

Codecov Report

Attention: Patch coverage is 15.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 47.19%. Comparing base (d0db41c) to head (cb06367).
Report is 7 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (d0db41c) and HEAD (cb06367). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d0db41c) HEAD (cb06367)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2466       +/-   ##
============================================
- Coverage    69.05%   47.19%   -21.86%     
============================================
  Files          308      444      +136     
  Lines        19192    29372    +10180     
============================================
+ Hits         13253    13863      +610     
- Misses        5264    14704     +9440     
- Partials       675      805      +130     
Files Coverage Δ
x/crosschain/keeper/cctx_gateway_zevm.go 100.00% <100.00%> (ø)
x/fungible/keeper/evm.go 88.23% <100.00%> (+0.42%) ⬆️
rpc/types/utils.go 0.00% <0.00%> (ø)
...2etests/test_message_passing_evm_to_zevm_revert.go 0.00% <0.00%> (ø)

... and 174 files with indirect coverage changes