Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: more docker compose deduplicating #2415

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Jul 1, 2024

Description

Continue to reduce the number of docker compose files by using profiles. This is cool because it you can request multiple profiles at the same time to test more complex scenarios. Imagine running stress + upgrade or stress+admin+eth2 etc.

Getting all the services in one compose file is good because you can easily see IP address conflicts. It's also more obvious what needs to be updated when you're refactoring things. The stress tests were actually broken because I forgot to update the docker-compose-stress.yml.

Also detect presence of other containers (eth2, zetacored replicas) via dns resolution rather that static config. Example output from zetaclient now:

Waiting for zetacore0 rpc
operatorAddress: zeta12x9lynrkr7y9q58kdtdapn3pvawcrnlldvzjpl
Start zetaclientd
eth2 has address 172.20.0.102
enabling additional evm (eth2)

How Has This Been Tested?

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Copy link
Contributor

coderabbitai bot commented Jul 1, 2024

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (8)
  • Dockerfile-localnet is excluded by none and included by none
  • Makefile is excluded by none and included by none
  • contrib/localnet/docker-compose-additionalevm.yml is excluded by none and included by none
  • contrib/localnet/docker-compose-stress.yml is excluded by none and included by none
  • contrib/localnet/docker-compose-upgrade.yml is excluded by none and included by none
  • contrib/localnet/docker-compose.yml is excluded by none and included by none
  • contrib/localnet/scripts/start-zetaclientd.sh is excluded by none and included by none
  • contrib/localnet/scripts/start-zetacored.sh is excluded by none and included by none

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gartnera gartnera requested a review from a team July 1, 2024 19:09
Copy link
Contributor

@swift1337 swift1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some comments

contrib/localnet/docker-compose.yml Show resolved Hide resolved
contrib/localnet/docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might see it could be used for #2373?
cc @kingpinXD

@gartnera gartnera force-pushed the more-compose-dedup branch from 61a8fc3 to c506bd7 Compare July 2, 2024 15:56
@gartnera gartnera added the no-changelog Skip changelog CI check label Jul 2, 2024
Copy link
Contributor

@CryptoFewka CryptoFewka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@gartnera gartnera enabled auto-merge (squash) July 2, 2024 16:14
@gartnera gartnera merged commit 41c6ef2 into develop Jul 2, 2024
19 of 20 checks passed
@gartnera gartnera deleted the more-compose-dedup branch July 2, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants