-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: more docker compose deduplicating #2415
Conversation
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (8)
You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might see it could be used for #2373?
cc @kingpinXD
61a8fc3
to
c506bd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Description
Continue to reduce the number of docker compose files by using profiles. This is cool because it you can request multiple profiles at the same time to test more complex scenarios. Imagine running stress + upgrade or stress+admin+eth2 etc.
Getting all the services in one compose file is good because you can easily see IP address conflicts. It's also more obvious what needs to be updated when you're refactoring things. The stress tests were actually broken because I forgot to update the
docker-compose-stress.yml
.Also detect presence of other containers (eth2, zetacored replicas) via dns resolution rather that static config. Example output from zetaclient now:
How Has This Been Tested?