Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zetaclient): add support for EIP-1559 outbound transactions #2387

Closed
wants to merge 17 commits into from

Merge branch 'develop' into feat/zetaclient-london-gas

07999ec
Select commit
Loading
Failed to load commit list.
Closed

feat(zetaclient): add support for EIP-1559 outbound transactions #2387

Merge branch 'develop' into feat/zetaclient-london-gas
07999ec
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks failed Jul 1, 2024 in 1s

12 secrets uncovered!

12 secrets were uncovered from the scan of 17 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #2387: feat/zetaclient-london-gas 👉 develop
GitGuardian id GitGuardian status Secret Commit Filename
11033143 Triggered Generic High Entropy Secret 3bc0394 cmd/zetae2e/local/accounts.go View secret
11033143 Triggered Generic High Entropy Secret 3bc0394 cmd/zetae2e/config/localnet.yml View secret
11033143 Triggered Generic High Entropy Secret 3bc0394 cmd/zetae2e/config/local.yml View secret
11033144 Triggered Generic High Entropy Secret 3bc0394 cmd/zetae2e/config/localnet.yml View secret
11033144 Triggered Generic High Entropy Secret 3bc0394 cmd/zetae2e/local/accounts.go View secret
11033145 Triggered Generic High Entropy Secret 3bc0394 cmd/zetae2e/local/accounts.go View secret
11033145 Triggered Generic High Entropy Secret 3bc0394 cmd/zetae2e/config/localnet.yml View secret
11033146 Triggered Generic High Entropy Secret 3bc0394 cmd/zetae2e/local/accounts.go View secret
11033146 Triggered Generic High Entropy Secret 3bc0394 cmd/zetae2e/config/localnet.yml View secret
11478175 Triggered Generic High Entropy Secret 3bc0394 cmd/zetae2e/config/localnet.yml View secret
11478176 Triggered Generic High Entropy Secret 3bc0394 cmd/zetae2e/config/localnet.yml View secret
11759679 Triggered Generic High Entropy Secret 3bc0394 cmd/zetae2e/local/accounts.go View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.