-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set 1000 sats as minimum amount that can be withdrawn #2362
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2362 +/- ##
========================================
Coverage 68.67% 68.68%
========================================
Files 304 304
Lines 19154 19159 +5
========================================
+ Hits 13154 13159 +5
Misses 5351 5351
Partials 649 649
|
LGTM, |
I mean, would it make sense to add an e2e test and check the balance? The user should not have any loss of funds I guess , since the PostTxProcessing hook reverts the entire tx? If you think an e2e test is not necessary just checking it would be a good idea |
Seems just checking is okay. Also the 'unsupported address' validation was tested against mainnet on v17 release, the zEVM 'withdraw' tx just failed. |
Description
This PR is to prevent Bitcoin dust-amount withdrawals from registration. It set
1000 satoshis
as the minimum amount that can be withdrawn from zEVM.Closes: 2326
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: