New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): `TestBitcoinDepositRefund`, `WithdrawBitcoinMultipleTimes` #2349

Merged

swift1337 merged 22 commits into develop from test/deposit-btc-refund

Jun 20, 2024

Contributor

swift1337 commented Jun 18, 2024 •

edited

Loading

Description

This PR adds E2E tests for TestBitcoinDepositRefund and WithdrawBitcoinMultipleTimes. It also introduces several improvements to testing suite:

Support for testify's assert and require packages in e2e testing
Support for debugging e2e test using Delve debugger ./e2e/scripts/debug.sh $test $args
Shortcut for running a single e2e test ./e2e/scripts/run.sh $test $args
Support for utils.WaitCctxByInboundHash() with some handy filters

Closes: #1469

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

Checklist:

I have added unit tests that prove my fix feature works

swift1337 added 7 commits

June 18, 2024 18:29


          Add debugging capabilities to e2e tests (Delve)

48fc416


          Add make start-localnet-skip-build

9d03725


          Bump github.com/rjeczalik/notify to fix Apple ARM issue (rjeczalik/no…

…tify#212)


          Add run.sh for a single e2e test run

c13d7f0


          Add testify support for e2e runner

acc3674


          Minor refactoring

1ddaa2d


          WIP TestDepositBTCRefund

ecb37c7

swift1337 self-assigned this

github-actions bot added the breaking:cli label

lumtis reviewed

View reviewed changes

e2e/e2etests/e2etests.go Outdated Show resolved Hide resolved

e2e/e2etests/e2etests.go Outdated Show resolved Hide resolved

e2e/e2etests/e2etests.go Outdated Show resolved Hide resolved

e2e/e2etests/test_bitcoin_deposit_refund.go Outdated Show resolved Hide resolved

swift1337 added 2 commits

June 19, 2024 12:28

WIP

fc21fa7


          Fix naming

1e9506f

swift1337 changed the title ~~test(e2e): DepositBTCRefund, WithdrawBitcoinMultipleTimes~~ test(e2e): TestBitcoinDepositRefund, WithdrawBitcoinMultipleTimes

lumtis reviewed

View reviewed changes

Member

lumtis left a comment

We'll need to add the new test in cmd/zetae2e/local/local.go to execute in CI

swift1337 and others added 7 commits

June 19, 2024 14:50


          WIP [2]


          Add test to CI

b1151ce


          Complete "btc deposit refund" test case

fcbc852


          Add WithdrawBitcoinMultipleTimes test

5254f39


          Merge branch 'develop' into test/deposit-btc-refund

3839a78


          Merge branch 'test/deposit-btc-refund' of github.com:zeta-chain/node …

287cad8

…into test/deposit-btc-refund


          Lint

b031671

swift1337 marked this pull request as ready for review

June 19, 2024 16:17

swift1337 requested review from brewmaster012, kingpinXD, ws4charlie and skosito as code owners

June 19, 2024 16:17

github-actions bot added the nosec label

zeta-chain deleted a comment from github-actions bot

swift1337 removed the nosec label

gartnera reviewed

View reviewed changes

e2e/e2etests/test_bitcoin_deposit_refund.go Show resolved Hide resolved

lumtis reviewed

View reviewed changes

e2e/README.md Outdated Show resolved Hide resolved

e2e/e2etests/helper_bitcoin.go Outdated Show resolved Hide resolved

e2e/e2etests/test_bitcoin_deposit_refund.go Show resolved Hide resolved

e2e/e2etests/helper_bitcoin.go Outdated Show resolved Hide resolved

e2e/e2etests/test_bitcoin_deposit_refund.go Show resolved Hide resolved

e2e/e2etests/test_bitcoin_deposit_refund.go Outdated Show resolved Hide resolved

e2e/e2etests/test_bitcoin_withdraw_multiple.go Show resolved Hide resolved

e2e/e2etests/test_bitcoin_deposit_refund.go Show resolved Hide resolved

e2e/e2etests/test_bitcoin_deposit_refund.go Outdated Show resolved Hide resolved


          Revert MD formatting

bda6bae

github-actions bot added the nosec label

zeta-chain deleted a comment from github-actions bot

swift1337 and others added 2 commits

June 20, 2024 13:11


          Address PR comments

23d29e5


          Merge branch 'develop' into test/deposit-btc-refund

a1e6c9f

zeta-chain deleted a comment from github-actions bot

zeta-chain deleted a comment from github-actions bot

zeta-chain deleted a comment from gitguardian bot

Member

lumtis commented Jun 20, 2024

Need to run

make generate

Note: don't be surprised, this command takes 2 min because we run formatter in the entire codebase (we might want to find some optimization on this)

swift1337 added 2 commits

June 20, 2024 13:35


          Lint

ab403af


          Merge branch 'test/deposit-btc-refund' of github.com:zeta-chain/node …

ed2285a

…into test/deposit-btc-refund

zeta-chain deleted a comment from gitguardian bot

zeta-chain deleted a comment from github-actions bot

lumtis approved these changes

View reviewed changes

Member

lumtis left a comment

👍

skosito approved these changes

View reviewed changes

Contributor

skosito left a comment

looks good, left some comments, please check before merge if they make sense

e2e/e2etests/test_bitcoin_withdraw_multiple.go Show resolved Hide resolved

e2e/runner/runner.go Show resolved Hide resolved

e2e/runner/bitcoin.go Show resolved Hide resolved

e2e/e2etests/helpers.go Show resolved Hide resolved

e2e/e2etests/helpers.go Outdated Show resolved Hide resolved

e2e/scripts/debug.sh Outdated Show resolved Hide resolved

e2e/scripts/run.sh Show resolved Hide resolved

e2e/utils/zetacore.go Show resolved Hide resolved

go.mod Show resolved Hide resolved


          Address PR comments [2]

d956db4

zeta-chain deleted a comment from gitguardian bot

zeta-chain deleted a comment from github-actions bot

swift1337 merged commit 5e3c3ba into develop

18 of 19 checks passed

swift1337 deleted the test/deposit-btc-refund branch

June 20, 2024 14:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gartnera gartnera left review comments

skosito skosito approved these changes

lumtis lumtis approved these changes

brewmaster012 Awaiting requested review from brewmaster012

kingpinXD Awaiting requested review from kingpinXD

ws4charlie Awaiting requested review from ws4charlie

Labels

breaking:cli nosec