-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: revert telemetry server changes #2325
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2325 +/- ##
===========================================
- Coverage 68.30% 68.06% -0.24%
===========================================
Files 299 299
Lines 18905 18971 +66
===========================================
Hits 12913 12913
- Misses 5355 5421 +66
Partials 637 637
|
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
has this been tested in localnet? |
yes i tested locally that following endpoints on 8123 work, and values are present in metrics on 8886 as well:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM .
Minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Revert handlers in ts on port 8123. It was replaced by metrics in this PR: #1885
In this PR it is reverted, but metrics are still updated. Also changed last scanned block number to have chainName as label same as metrics.
Closes: #2324
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: