Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: perform some various renaming fixes #2323

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Jun 5, 2024

Description

Address some of the points of the attached renaming issue.
Some were left untouched:

  • renaming ob: I think ob naming is fine now that we have refactoring the observer object into its own package
  • Cctx, Tss -> CCTX, TSS: this would be part of a bigger refactoring as some message would need to be changed and implying breaking changes. Also we will still have some occurences since proto generation doesn't recognize acronyms (this is the same for Btc -> BTC and Eth -> ETH)

Closes: #2027

@lumtis lumtis added the no-changelog Skip changelog CI check label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 48.38710% with 16 lines in your changes missing coverage. Please review.

Project coverage is 68.30%. Comparing base (3f02526) to head (d7c196d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2323   +/-   ##
========================================
  Coverage    68.30%   68.30%           
========================================
  Files          299      299           
  Lines        18905    18905           
========================================
  Hits         12913    12913           
  Misses        5355     5355           
  Partials       637      637           
Files Coverage Δ
x/crosschain/keeper/cctx_gateway_zevm.go 100.00% <100.00%> (ø)
x/crosschain/keeper/process_outbound.go 94.01% <100.00%> (ø)
x/crosschain/types/cctx.go 95.41% <100.00%> (ø)
x/observer/keeper/msg_server_vote_block_header.go 92.59% <100.00%> (ø)
x/observer/keeper/vote_inbound.go 88.57% <100.00%> (ø)
x/observer/keeper/vote_outbound.go 88.88% <100.00%> (ø)
zetaclient/chains/evm/observer/inbound.go 41.32% <100.00%> (ø)
zetaclient/orchestrator/orchestrator.go 25.40% <ø> (ø)
zetaclient/zetacore/tx.go 53.72% <ø> (ø)
zetaclient/chains/bitcoin/observer/inbound.go 14.72% <0.00%> (ø)
... and 3 more

@lumtis lumtis merged commit 3fd9c9a into develop Jun 7, 2024
18 of 19 checks passed
@lumtis lumtis deleted the some-renaming branch June 7, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:proto no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use consistent naming in ZetaClient
3 participants