-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CheckAuthorization function #2313
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2313 +/- ##
===========================================
+ Coverage 68.22% 68.26% +0.03%
===========================================
Files 298 298
Lines 18857 18880 +23
===========================================
+ Hits 12865 12888 +23
Misses 5355 5355
Partials 637 637
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the naming Authorizations
instead of AuthorizationsList
to make it consistent with Policies
The files are named after the data structures for which they have functions. |
@kingpinXD ready for re-review? |
Description
This prs adds a
CheckAuthorization
function to replace theIsAuthorized
function. The new function uses the authorization list to verify the signer's authorization.Closes: #2310
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: